Fixup genutil.py #307
Closed
Fixup genutil.py #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander McClain <[email protected]>
Signed-off-by: Alexander McClain <[email protected]>
`skip_junk` and `print_runs` were not used anywhere. Signed-off-by: Alexander McClain <[email protected]>
To follow the same naming convention as the surrounding functions. Signed-off-by: Alexander McClain <[email protected]>
The file had many formatting issues, the main ones being: 1. Many functions had 3 space indentation, which is inconsistent with the rest of the file's 4 space indentation. 2. No spaces between list and tuple elements 3. Extra spaces around list and tuple elements 4. Lack of space between function definitions (2 newlines is recommended) Signed-off-by: Alexander McClain <[email protected]>
There doesn't seem to be a need to manually write to stderr and exit here. Signed-off-by: Alexander McClain <[email protected]>
Signed-off-by: Alexander McClain <[email protected]>
This just makes it easier to visualize what these do. Signed-off-by: Alexander McClain <[email protected]>
|
Thanks for the great work. The changes will be available with the next XED external release. |
Thanks. Is there a planned release date? I'd like to have the current state of |
Early December |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #306 (comment).
There are no functionality changes, these are purely stylistic and QOL changes.
I started with
genutil.py, since it's used everywhere.This PR:
See the commit messages for explanations of the changes made.