-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docsrc: Update required python version in docs #306
Conversation
After some testing, it looks like the oldest python version XED/mbuild supports is 3.6. Signed-off-by: Alexander McClain <[email protected]>
Thanks. We're currently working on an update for XED documentation. (BTW, the minimal required Python version is 3.7) |
Ah, should I update the PR, or are you just going to update your local doc changes? Also, I'm interested in refactoring the Python code with better doc comments, type annotations, and more descriptive variable names. Would you guys be interested in such contributions? I've been trying to better understand the format of the data files, and since #39 is still WIP, I resorted to trying to read the source code here, and it's pretty difficult (since the things I listed above are pretty lackluster at the moment). |
There's no need to update this PR. I'll update it internally and publish it with the next XED external release.
It can be helpful, especially type annotations. We're constantly updating it, but it is really a step-by-step and incremental progress.
As far as I see, #42 adds a description for most of the datafiles topics. I wonder if I should close #39 ... |
#42 is definitely a start, but as mentioned in #39 (comment), it is only really a start. Currently, there are only short descriptions of files in
|
Oh yeah, take as much time as you need. Sorry if I made this seem like an immediately issue. 😄 I'll start adding types to the Python source, which I feel will help a lot where the documentation is lacking. |
After some testing, it looks like the oldest python version XED/mbuild supports is 3.6.