Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docsrc: Update required python version in docs #306

Closed
wants to merge 1 commit into from

Conversation

Serial-ATA
Copy link

After some testing, it looks like the oldest python version XED/mbuild supports is 3.6.

After some testing, it looks like the oldest python version XED/mbuild supports is 3.6.

Signed-off-by: Alexander McClain <[email protected]>
@marjevan
Copy link
Member

marjevan commented Nov 9, 2023

Thanks. We're currently working on an update for XED documentation.
I'll make sure this will be updated as well.

(BTW, the minimal required Python version is 3.7)

@marjevan marjevan marked this pull request as draft November 9, 2023 19:31
@Serial-ATA
Copy link
Author

(BTW, the minimal required Python version is 3.7)

Ah, should I update the PR, or are you just going to update your local doc changes?

Also, I'm interested in refactoring the Python code with better doc comments, type annotations, and more descriptive variable names. Would you guys be interested in such contributions?

I've been trying to better understand the format of the data files, and since #39 is still WIP, I resorted to trying to read the source code here, and it's pretty difficult (since the things I listed above are pretty lackluster at the moment).

@marjevan
Copy link
Member

Ah, should I update the PR, or are you just going to update your local doc changes?

There's no need to update this PR. I'll update it internally and publish it with the next XED external release.

Also, I'm interested in refactoring the Python code with better doc comments, type annotations, and more descriptive variable names. Would you guys be interested in such contributions?

It can be helpful, especially type annotations. We're constantly updating it, but it is really a step-by-step and incremental progress.
Sure, you're welcome to contribute. There's an option where we'll modify things to match the project standards, but a starting point can help us with a shorter shipping time.
Please follow the XED contributing guide: CONTRIBUTING.md

I've been trying to better understand the format of the data files, and since #39 is still WIP, I resorted to trying to read the source code here, and it's pretty difficult (since the things I listed above are pretty lackluster at the moment).

As far as I see, #42 adds a description for most of the datafiles topics. I wonder if I should close #39 ...
Let me know if there's anything else missing.

@Serial-ATA
Copy link
Author

Serial-ATA commented Nov 12, 2023

As far as I see, #42 adds a description for most of the datafiles topics. I wonder if I should close #39 ...
Let me know if there's anything else missing.

#42 is definitely a start, but as mentioned in #39 (comment), it is only really a start.

Currently, there are only short descriptions of files in engineering-notes.txt. The file could really use:

@marjevan
Copy link
Member

#42 is definitely a start, but as mentioned in [#39 (comment)]

I see.
We're currently swamped with a lot of tasks, but we'll do our best to help you out as soon as we can.
Thanks for your patience and understanding!

@Serial-ATA
Copy link
Author

Oh yeah, take as much time as you need. Sorry if I made this seem like an immediately issue. 😄

I'll start adding types to the Python source, which I feel will help a lot where the documentation is lacking.

@Serial-ATA Serial-ATA mentioned this pull request Nov 15, 2023
@sdeadmin sdeadmin closed this in 2b5c29a Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants