Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reqest for changes in Cmakelists file #77

Open
solomoncyj opened this issue Oct 10, 2024 · 1 comment
Open

Reqest for changes in Cmakelists file #77

solomoncyj opened this issue Oct 10, 2024 · 1 comment

Comments

@solomoncyj
Copy link

Hi Fedora packager. do you mind making the following edits tour your cmakelist file to make it easir to package this libary for Fedora? thanks

  • Use CMakePackageConfigHelpers macros 1 and include the safestringlibVersion.cmake file
  • Do not manually add compilation flags (it interferes with our optimization flags), instead move them to presets and only run them in the CI
  • Bump the minimum cmake version (if the minimum is too low, recent CMake changes and imporvements are not applied)
  • Consider migrating the includes into dedicated subfolder
@solomoncyj
Copy link
Author

@tomasbw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@solomoncyj