Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Factory design mode for ros2_openvino_toolkit #281

Open
gitpqLee opened this issue Apr 21, 2023 · 0 comments
Open

Introduce Factory design mode for ros2_openvino_toolkit #281

gitpqLee opened this issue Apr 21, 2023 · 0 comments
Labels
hackathon For hachathon/tests

Comments

@gitpqLee
Copy link
Contributor

gitpqLee commented Apr 21, 2023

The current programming modeling in the project is not friendly to add new extensions (e.g. adding new types of for Data Input, AI Model or Result Output).

We had been doing some attempts by adopting Factory design patterns in another repo ( PR support for ros_openvino_toolkit). And as a result of evaluation, we think the method is more friendly to new contributers and reducing the repeated code in the whole project.

So we want the tasks to be done such as:

  • Migrating the draft implementation into the repo(ROS2_OpenVINO_toolkit).
  • [Optional] Evaluate the impacts to the current functions (comparing with the functions once Factory mode adopted), document them or find the resolution.
@LewisLiuPub LewisLiuPub added good first issue Good for newcomers hackathon For hachathon/tests and removed good first issue Good for newcomers labels Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hackathon For hachathon/tests
Projects
None yet
Development

No branches or pull requests

2 participants