Fix validation of numeric types #69
Merged
Commits on Sep 24, 2024
-
Add column type validation tests for metrics/plot
Each of these functions requires some columns to be numeric. Signed-off-by: John Pennycook <[email protected]>
-
Add regression test for efficiency with string FOM
Signed-off-by: John Pennycook <[email protected]>
-
Replace _require_numeric with _cast_to_numeric
Whereas _require_numeric simply checked that the values in a DataFrame could be interpreted as numbers, _cast_to_numeric actually performs the cast and returns the result. Signed-off-by: John Pennycook <[email protected]>
-
Avoid false positives in _cast_to_numeric
Previously, _cast_to_numeric would raise a TypeError if a column was missing. We now check that a column exists before trying to cast it. This does result in some redundant checking, as some functions call both _require_columns and _cast_to_numeric. We may want to consider refactoring to combine all of this functionality into a single DataFrame validation step. Signed-off-by: John Pennycook <[email protected]>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.