Permit coverage JSON strings and objects #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although many of our early tests used coverage strings loaded from CSV files, we have encountered real use-cases where it is easier to work directly with coverage represented as Python objects. Signed-off-by: John Pennycook <[email protected]>
Previously, the test threw a TypeError because the JSON was provided as an object instead of as a string. Now that providing coverage objects is supported, the test is expected to throw a ValueError: it is valid to pass an object, but the object itself is invalid. Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Closes #60.
Proposed changes
test_coverage_json_invalidto reflect that passing objects is now valid.test_coverage_json_validto test JSON objects as well as JSON strings.