Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

02-fused-softmax: PyTorch faster than Triton on Max 1550 in composite mode #2363

Open
pbchekin opened this issue Sep 26, 2024 · 2 comments
Open

Comments

@pbchekin
Copy link
Contributor

ZE_FLAT_DEVICE_HIERARCHY=FLAT
softmax-performance

ZE_FLAT_DEVICE_HIERARCHY=COMPOSITE
softmax-performance

@chengjunlu
Copy link
Contributor

I think it maybe caused by the register spill.
In the composite mode, the private space for spilling maybe always allocated in one tile and all the threads on the other tile has to access the private space across the EMIB bus.

We may need to implement a new softmax kernel which is close to the torch's implementation and re-test the performance.

@anmyachev
Copy link
Contributor

@pbchekin in composite mode we need to adjust cache size (double it) #2265 (comment). I wonder how the chart will change after this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants