[NEXARL-306] Update prerm script to not disabling and stopping agents if it's an upgrade process #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's an upgrade process This PR updates the prerm script to prevent them from disabling and stopping if it's an upgrade process. Signed-off-by: yengliong <[email protected]>
|
@gblewis1 please have a review, thanks. |
|
@yengliong93 looks good but please run through integration tests |
gblewis1
approved these changes
Oct 1, 2024
|
Integration tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL DESCRIPTION
This PR updates the prerm script to prevent them from disabling and stopping if it's an upgrade process.
Impact Analysis
CODE MAINTAINABILITY
go fmtorformat-python.shas applicableCode must act as a teacher for future developers