-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEXMANAGE-515][NEXMANAGE-598] Support TiberOS #543
Conversation
This PR updates the INBM to support TiberOS SOTA. Signed-off-by: yengliong <[email protected]>
8be47e4
to
0819f0b
Compare
b25bf59
to
ea86d71
Compare
ea86d71
to
84f55a5
Compare
….literal_eval per AI recommendation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't merge yet -- let's hold in a branch as optimization effort for Turtle Creek is pending. We want to make sure we are including INBM in Tiber OS before this is merged.
Added the fix to address issue in NEXMANAGE-734. |
I want to run the integration test but the docker pull rate limitation encountered. |
Integration test passes. |
The PR review is to check for sustainability and correctness. Sustainability is actually more business critical as correctness is largely tested into the code over time. Its useful to keep in mind that SW often outlives the HW it was written for and engineers move from job to job so it is critical that code developed for Intel be supportable across many years. It is up to the submitter and reviewer to look at the code from a perspective of what if we have to debug this 3 years from now after the author is no longer available and defect databases have been lost. Yes, that happens all the time when we are working with time scales of more than 2 years. When reviewing your code it is important to look at it from this perspective.
Author Mandatory (to be filled by PR Author/Submitter)
PULL DESCRIPTION
This PR updates the INBM and INBC to support TiberOS SOTA.
Added TiberOS as the new OS to be detected.
Updated dispatcher to record the tiberos-version in dispatcher_state file. This is used to compare the version of the image after reboot.
Added ORAS util for using the ORAS tool to download the image.
In TiberOS, INBM uses UpdateTool (UT) to perform the image A/B based update.
The granular log method has been enhanced to record the details of the SOTA in TiberOS.
Some opens:
REFERENCES
Reference URL for issue tracking (JIRA/HSD/Github): <URL to be filled>
Note-1: Depending on complexity of code changes, use the suitable word for complexity: Low/Medium/High
Example: PR for Slim boot loader project with medium complexity can have the label as: ISDM_Medium
CODE MAINTAINABILITY
APPLICATION SPECIFIC
Maintainer Mandatory (to be filled by PR Reviewer/Approving Maintainer)
QUALITY CHECKS
CODE REVIEW IMPACT
Note P1/P2/P3/P4 denotes severity of defects found (Showstopper/High/Medium/Low) and xx denotes number of defects found
SECURITY CHECKS
Please check if your PR fulfills the following requirements:
Code must act as a teacher for future developers