Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(parser): add conan parser #4569

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(parser): add conan parser #4569

wants to merge 4 commits into from

Conversation

AryanBakliwal
Copy link
Contributor

fixes: #4265

Added Conan package parser for C/C++.

@AryanBakliwal
feat(parser): add conan parser
9c3f88c 
Signed-off-by: Aryan Bakliwal <[email protected]>
@AryanBakliwal
Copy link
Contributor Author

Hey @mastersans, could you please take a look and let me know if any change is required. I did test it and it is working as expected with the test passing locally.

mastersans
mastersans reviewed Nov 18, 2024
View reviewed changes
Copy link
Member

@mastersans mastersans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Thanks for the PR, Looks good to me, I have minor nit pick, @terriko might have something more to say.

cve_bin_tool/parsers/ccpp.py Show resolved Hide resolved
doc/MANUAL.md Show resolved Hide resolved
test/language_data/conan.lock Outdated Show resolved Hide resolved
cve_bin_tool/parsers/ccpp.py Outdated Show resolved Hide resolved
terriko
terriko requested changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks promising. I'd like you to address @mastersans 's suggestions, particularly providing a link for some info about the conan.lock file format. But I'll get the tests running for you now.

@terriko
Copy link
Contributor

terriko commented Nov 26, 2024

I've kicked off the tests to run. I'm still seeing some weirdness about the longtests (which have to pass before I can merge anything due to our branch rules) so if those fail due to timeout we may have other problems to resolve before this can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastersans mastersans mastersans left review comments

@terriko terriko Awaiting requested review from terriko

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: "language" parser for Conan [ C/C++ ]
3 participants
@AryanBakliwal @terriko @mastersans