Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor and clean up pseudo_pext benchmark python code #561

Open
lukevalenty opened this issue Jun 14, 2024 · 1 comment
Open

refactor and clean up pseudo_pext benchmark python code #561

lukevalenty opened this issue Jun 14, 2024 · 1 comment

Comments

@lukevalenty
Copy link
Contributor

Lots of feedback to refactor the pseudo_pext benchmark code in #535, this issue is being filed to track it's completion.

@elbeno
Copy link
Contributor

elbeno commented Jun 17, 2024

  • the pseudo_pext benchmark code needs to be moved out of the test area and into a separate benchmarking area
  • benchmarking targets shouldn't be part of the ALL target
  • pseudo_pext.cpp uses a C++23 feature (static variable in constexpr function); either needs to be changed for C++20 or run only with appropriate toolchains
  • move the python scripts to a better place, clean them up
  • generate the tables with gen_map_data.py as part of the build; don't keep generated source in the repo
  • pseudo_pext.cpp crashes clang-18; doesn't build with clang-17 or gcc-13 (what I've tried so far)
  • benchmark tests run with a post build step; better to use the pattern in the CICD repo. (Using build events in CMake is perhaps a code smell? BEs can't have dependencies.)

elbeno added a commit to elbeno/compile-time-init-build that referenced this issue Jun 17, 2024
The pseudo pext code needs more help; I can't even build it yet (tried clang 17,
18, gcc 13).

I've started making a task list in issue intel#561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants