Incorrect handling of CRC

[jposwiata]

In CRC and COPY_WITH_CRC commands it is not allowed to set initial CRC values after PAGE_FAULT with no bytes processed.
update_crc_for_continuation() and update_copy_crc_for_continuation() should include the conditon:

if (crc_record.bytes_completed() != 0) {
    crc_dsc.crc_seed() = crc_record.crc_value();
}

[abdelrahim-hentabli]

Hey @jposwiata, crc_record.crc_value() would be initialized with the crc_seed, even in the case of crc_record.bytes_completed() == 0.

So in the case of crc_record.bytes_completed() == 0 the line crc_dsc.crc_seed() = crc_record.crc_value(); would be equivalent to crc_dsc.crc_seed() = crc_dsc.crc_seed();

[jposwiata]

the documentation says: if Bytes Completed is 0, the CRC Value in the completion record is undefined and software should reuse the CRC Seed or CRC Seed Address from the descriptor.

According our experiments "output" CRC is in most cases zeroed.