Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppressing error in webhooks controller makes testing more difficult #56

Closed
skalb opened this issue Apr 13, 2015 · 3 comments
Closed

Comments

@skalb
Copy link

skalb commented Apr 13, 2015

In my case, I couldn't figure out why the spec was failing (I hadn't stubbed auth correctly) and had to manually call StripeEvent.instrument in my test.

I'm not super familiar with Engines--is there way to propagate the error and let the client decide how to handle it? And/or add a logging statement?

Thanks for the great work!

Edit: referring to https://github.com/integrallis/stripe_event/blob/master/app/controllers/stripe_event/webhook_controller.rb#L14

@rmm5t rmm5t closed this as completed in 35325f2 Sep 27, 2015
@jasonkarns
Copy link

jasonkarns commented Apr 3, 2018

Agree. This is a problem we're facing as well as we'd like to report stripe_event exceptions to our error monitoring tool. Can this be reopened?

@rmm5t
Copy link
Member

rmm5t commented Apr 3, 2018

@jasonkarns It was closed because the specific feature that was requested was added in 35325f2.

What you're asking for is slightly different. It sounds like you'd like a way to hook into the exception handling and drive it to your monitoring and error-reporting toolchain.

Would you mind opening a new Issue while also elaborating on your specific use-case?

@jasonkarns
Copy link

roger, thanks!

#110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants