Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement an exponential backoff retry for unsollicitated token renewal #956

Open
NFRBEZ opened this issue Jul 6, 2023 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@NFRBEZ
Copy link

NFRBEZ commented Jul 6, 2023

Purpose of the feature (why)

From now, when token is not valid, the browser is getting open every 5 min, polluting browser of these windows

Your idea (how)

Implement an exponential backoff retry capped at like 4h, because if there is one unfullfilled unsollicitated attempt in the 5 min, there is very high chance that it would be the same in the next 5 min.

So for example, it could be nice to retry in the next 30 min, then in the next hour, then in the next 4 hour, so there is at most 8 unsollicitated request the first day, then 6 each day follow.
At any time, if the user want to execute a kubectl query, it would imply trigger an authentication request. So from my point of view, these retry mechanisms isn't valuable, but modulating it could be a a nice workaround

@NFRBEZ NFRBEZ added the enhancement New feature or request label Jul 6, 2023
adsharma added a commit to adsharma/kubelogin that referenced this issue Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant