Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradebook and Grading Scheme Not Working Properly Upon Update #2423

Open
jenniferhelbley opened this issue Oct 25, 2024 · 13 comments
Open

Gradebook and Grading Scheme Not Working Properly Upon Update #2423

jenniferhelbley opened this issue Oct 25, 2024 · 13 comments

Comments

@jenniferhelbley
Copy link

jenniferhelbley commented Oct 25, 2024

Summary:

I am using the community edition of Canvas (not hosted by Instructure) and we recently did an update from an older version. (I know we should have been doing incremental updates, but I only have so much time in my life.) Nearly everything is working or working super good enough but I have two problems that I just can't track down the why or how. I'm not sure if they are connected but it feels like they are.

  1. Instructor view of gradebook works most of the time, but every now and again something gets saved in an instructors profile that sets the gradebook to view from external source and then the instructor can't view the gradebook. I thought it was due to an external tool being used but then I had one of my instructors that most definitely does not use any external tools and (as far as I know) also has never updated grades by importing a csv so I am stumped what could possibly be changing this setting. It works if I delete their gradebook view profile using ssh, but that isn't very practical long term. (View below.)
    gradebook view not working

  2. Grading schemes no longer work. It seems to be stuck somewhere in the old view and new grade schemes view. I can create a new grade scheme but it isn't selectable in a course. I tried all (I think) of the various permutations of order of operations setting the grading scheme/editing the grading scheme/update course details/going to manage grading schemes. But I still can't get it to apply to a course or even let me search grading schemes. When I do go looking at the grading schemes for a course, I find all the ones I created, but none can be applied.
    grade scheme set

If anyone has any thoughts on where to look to trace these errors that would be great. Thanks in advance!

@amg-web
Copy link
Contributor

amg-web commented Oct 28, 2024

same to me
i see following in browser's console while trying to get list of custom grades.

jquery.js:1489 Uncaught Error: Syntax error, unrecognized expression: .assessed_assignment?
    at et.error (jquery.js:1489:12)
    at ef (jquery.js:2155:8)
    at e_ (jquery.js:2614:20)
    at Function.et (jquery.js:941:9)
    at Function.<anonymous> (jquery-migrate.js:266:17)
    at t.<computed> [as find] (jquery-migrate.js:181:20)
    at t.<computed>.find (jquery.js:2824:11)
    at i (templateData.js:63:33)
    at a.fn.fillTemplateData (templateData.js:52:38)
    at index.js:226:20

@jenniferhelbley
Copy link
Author

Thanks amg-web for confirming I'm not the only one with a problem with gradebook.
In the browser console I get the very vague error:
Failed to load resource: the server responded with a status of 500 ()

@amg-web
Copy link
Contributor

amg-web commented Oct 28, 2024

@jenniferhelbley
it's related to this i think #2331

@DoctorOgg
Copy link

@jenniferhelbley it's related to this i think #2331

not sure it is, as the security.yml looks correct

production:
  encryption_key: [REDACTED]
  lti_iss: 'https://lms.[REDACTED]'

@DoctorOgg
Copy link

i should clarify that my comments are specifically to @jenniferhelbley conserns, as i am also helping her with her install.

@jenniferhelbley
Copy link
Author

With the Thanksgiving Break, I had some time to do a little bit more digging on the gradebook view issue. I still need to do some more work on the Grade Scheme issue.
What I know for sure now is that gradebook_settings->:external is the problem.
I can duplicate that getting set to external by doing the following in the gradebook:

  1. sort the grades by total (either high to low or low to high)
  2. refresh the grades page
    This triggers the following tow items being set in the user preferences file
    :gradebook_column_order=>:external, :gradebook_settings=>:external}
    But I only need to delete the gradebook_settings for the gradebook to load correctly.

@amg-web
Copy link
Contributor

amg-web commented Nov 26, 2024

I checked even February 2024 canvas version - issue exists.
I could not find why js looks for key .assessed_assignment? with dot as first symbol, while json data returned does not have it in a key name.
Any Ideas where to fix?
Screenshot from 2024-11-26 13-29-26

@va7map
Copy link
Contributor

va7map commented Nov 27, 2024

@jenniferhelbley The Gradebook bug has something to do with the submissions data being incomplete at the time it's loaded asynchronously, shortly after the initial page load. I didn't dig too deep as I found that enabling Enhanced Gradebook Filters avoids the bug altogether.

@amg-web At some point, the object keys are converted into CSS class selectors, and anything with a question mark triggers an unrecognized expression syntax error in jQuery. You can try deleting standard["assessed_assignment?"] before the object is used in ui/shared/grading-standards/jquery/index.js on line 235 and line 447. You'd also want to remove the unnecessary comma following input.grading_standard_id on line 378 to avoid another syntax error.

@jenniferhelbley
Copy link
Author

Thanks @va7map!!! enabling the Enhanced Gradebook Filters fixed up the gradebook breaking and was a super quick fix.

I'll have to try out the suggested fix for the grading scheme.

@jenniferhelbley
Copy link
Author

Thanks @va7map!!! enabling the Enhanced Gradebook Filters fixed up the gradebook breaking and was a super quick fix.

Worked the first time I tried to sort & refresh but now not working again. I'll try seeing what other gradebook features I turned off and hopefully one of the other preview features will fix it when I turn on both together.

@jenniferhelbley
Copy link
Author

I ended up setting my gradebook_settings value to nil and seeing how that will work as trying turning off/on various settings wasn't working. We'll see how much of a long term solution this is or if it gets overridden.

@amg-web
Copy link
Contributor

amg-web commented Nov 28, 2024

i'm not strong in js, but
here it calls a function to pars json

const url = $find.find('.grading_standards_url').attr('href')

then here this data is processed
const $found_all = this.find('.' + item)

@amg-web
Copy link
Contributor

amg-web commented Nov 28, 2024

grading scheme selector works on origin/stable/2023-12-06
oh Feb 2024 or newer it's not working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants