From 0aa5e8dde88c6bf7a1801a29f5a23fa26c0efb2f Mon Sep 17 00:00:00 2001
From: Ismael Bejarano <ibejarano@manas.tech>
Date: Wed, 12 Jun 2024 18:04:34 -0300
Subject: [PATCH] * Add unique constraint to region's for (country, name,
 admin_level) * Use upsert to update region's geometry

---
 .../068-add_regions_name_index.down.sql       |  1 +
 .../068-add_regions_name_index.up.sql         |  1 +
 scripts/population/load-regions               | 40 +++++--------------
 3 files changed, 13 insertions(+), 29 deletions(-)
 create mode 100644 resources/migrations/068-add_regions_name_index.down.sql
 create mode 100644 resources/migrations/068-add_regions_name_index.up.sql

diff --git a/resources/migrations/068-add_regions_name_index.down.sql b/resources/migrations/068-add_regions_name_index.down.sql
new file mode 100644
index 00000000..3c38705d
--- /dev/null
+++ b/resources/migrations/068-add_regions_name_index.down.sql
@@ -0,0 +1 @@
+ALTER TABLE regions DROP CONSTRAINT "regions_name_index";
diff --git a/resources/migrations/068-add_regions_name_index.up.sql b/resources/migrations/068-add_regions_name_index.up.sql
new file mode 100644
index 00000000..e4f3df33
--- /dev/null
+++ b/resources/migrations/068-add_regions_name_index.up.sql
@@ -0,0 +1 @@
+ALTER TABLE regions ADD CONSTRAINT "regions_name_index" UNIQUE ("country", "name", "admin_level");
diff --git a/scripts/population/load-regions b/scripts/population/load-regions
index ea1ea91b..8ea19bb1 100755
--- a/scripts/population/load-regions
+++ b/scripts/population/load-regions
@@ -48,7 +48,7 @@ fi
 
 DATA_PATH=${DATA_PATH:-/data}/geojson
 
-mkdir -p ${DATA_PATH}
+mkdir -p "${DATA_PATH}"
 
 # if the folder (still) doesn't exist then exit with error
 if [[ ! -e ${DATA_PATH}/$COUNTRY_CODE ]]; then
@@ -77,38 +77,18 @@ for i in $LEVELS; do
     # Simplify using distance
     OFILE=${DATA_PATH}/${COUNTRY_CODE}/${COUNTRY_CODE}_adm${i}_${INTERVAL_DISTANCE}.geojson
 
-    mapshaper $FILE -simplify interval=$INTERVAL_DISTANCE -o $OFILE
+    mapshaper "$FILE" -simplify interval=$INTERVAL_DISTANCE -o "$OFILE"
 
-    SIZE=$(stat --printf="%s" $FILE)
-    OSIZE=$(stat --printf="%s" $OFILE)
+    SIZE=$(stat --printf="%s" "$FILE")
+    OSIZE=$(stat --printf="%s" "$OFILE")
 
     echo "   -> Finished file size went from $SIZE to $OSIZE"
   fi
 
-  if [ "$FORCE" = "1" ]; then
-    psql -q -d $POSTGRES_DB -U $POSTGRES_USER -h $POSTGRES_HOST -p $POSTGRES_PORT << SQL_SCRIPT
+  psql -q -d $POSTGRES_DB -U $POSTGRES_USER -h $POSTGRES_HOST -p $POSTGRES_PORT << SQL_SCRIPT
 
-      WITH data AS (SELECT \$$`cat $OFILE`\$$::json AS fc)
-      UPDATE "regions" SET the_geom=f.the_geom
-      FROM (
-        SELECT
-          '${COUNTRY_NAME}' as country,
-          feat#>>'{properties,name}' AS name,
-          ${i} as admin_level,
-          ST_SetSRID(ST_CollectionExtract(ST_Multi(ST_GeomFromGeoJSON(feat->>'geometry')), 3), 4326) as the_geom
-        FROM (
-          SELECT json_array_elements(fc->'features') AS feat
-          FROM data
-        ) AS dummy
-      ) AS f
-      WHERE regions.country=f.country AND regions.name=f.name AND regions.admin_level=f.admin_level;
-
-SQL_SCRIPT
-  else
-    psql -q -d $POSTGRES_DB -U $POSTGRES_USER -h $POSTGRES_HOST -p $POSTGRES_PORT << SQL_SCRIPT
-
-      WITH data AS (SELECT \$$`cat $OFILE`\$$::json AS fc)
-      INSERT INTO "regions" (country, name, admin_level, the_geom)
+    WITH data AS (SELECT \$$`cat "$OFILE"`\$$::json AS fc)
+    INSERT INTO "regions" (country, name, admin_level, the_geom)
       SELECT
         '${COUNTRY_NAME}',
         feat#>>'{properties,name}' AS name,
@@ -117,10 +97,12 @@ SQL_SCRIPT
       FROM (
         SELECT json_array_elements(fc->'features') AS feat
         FROM data
-      ) AS f;
+      ) AS f
+    ON CONFLICT ON CONSTRAINT regions_name_index DO
+      UPDATE SET the_geom=excluded.the_geom;
 
 SQL_SCRIPT
-  fi
+
   # TODO: print errors
   echo " done!"
 done;