Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form validations type needs fixing. #371

Open
vdoss opened this issue Oct 8, 2019 · 2 comments
Open

Form validations type needs fixing. #371

vdoss opened this issue Oct 8, 2019 · 2 comments

Comments

@vdoss
Copy link

vdoss commented Oct 8, 2019

Using any FormComponent in typescript with validations throws following type error.

... is missing the following properties from type 'Validations': contains, equals, isAlpha, isAlphanumeric, and 62 more.

The FormComponent.d.ts needs following change.

type Validations = Partial<{ [Key in keyof Validators]: ParametersAfterFirst<Validators[Key]> }>
@jpjjulie
Copy link

Hi,
Can I please work on this fix? Thanks.

@vdoss
Copy link
Author

vdoss commented Oct 17, 2019

Yes, pl. do. I didn't get time to get to it. Thanks.

jpjjulie pushed a commit to jpjjulie/Snacks that referenced this issue Oct 18, 2019
Fix instacart#371 : Form validations type fixed
186b2fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpjjulie @vdoss