Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove function call from package using :: for fully imported packages #337

Open
kartikeyakirar opened this issue Oct 12, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@kartikeyakirar
Copy link
Contributor

kartikeyakirar commented Oct 12, 2023

Feature description

Based on the conversation #336 (comment), it has been observed that there is a package-wide usage of the :: namespace call for function from the fully imported packages.

Acceptance Criteria:
To meet the acceptance criteria, we need to remove these namespace references (from packages that are fully imported) and ensure that everything functions as expected.

@kartikeyakirar kartikeyakirar added the enhancement New feature or request label Oct 12, 2023
@kartikeyakirar
Copy link
Contributor Author

Additional Comments:
In most other teal modules, the convention is to include the package name before package functions. This practice enhances the debugging experience when working with functions. Perhaps this convention could also be applied here to maintain consistency across all nest packages.

@danielinteractive
Copy link
Collaborator

The point is that when the whole of another package is imported (that is, copied into our namespace) then it does not make sense to still access the functions in the other namespace.

@danielinteractive danielinteractive changed the title remove function call from pacakge using :: for imported packages remove function call from package using :: for fully imported packages Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants