Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DESCRIPTION #1315

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Update DESCRIPTION #1315

merged 1 commit into from
Jan 17, 2025

Conversation

shajoezhu
Copy link
Contributor

Pull Request

Fixes #nnn

Copy link
Contributor

github-actions bot commented Jan 17, 2025

Unit Tests Summary

    1 files     70 suites   1h 9m 12s ⏱️
  727 tests   614 ✅ 113 💤 0 ❌
1 987 runs  1 759 ✅ 228 💤 0 ❌

Results for commit dac8423.

♻️ This comment has been updated with latest results.

@m7pr
Copy link
Contributor

m7pr commented Jan 17, 2025

@shajoezhu I am working on fixing Scheduled job in tmc,
I also have tern version update in my PR, but it doesnt fix the build as the build somehow still installs tern 0.9.6
PR: #1314

Build: https://github.com/insightsengineering/teal.modules.clinical/actions/runs/12826566254/job/35766740791#step:9:765

@shajoezhu shajoezhu enabled auto-merge (squash) January 17, 2025 15:27
@shajoezhu
Copy link
Contributor Author

@shajoezhu I am working on fixing Scheduled job in tmc, I also have tern version update in my PR, but it doesnt fix the build as the build somehow still installs tern 0.9.6 PR: #1314

Build: https://github.com/insightsengineering/teal.modules.clinical/actions/runs/12826566254/job/35766740791#step:9:765

I think it should be fine now. with pak, it search for the latest release tag on tern repo, that is why you probably get 0.9.6, the tag is just made, and cran released. so we should be ok now.

Copy link
Contributor

Unit Test Performance Difference

Test suite performance difference
Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_mmrm 💚 $745.90$ $-6.56$ $0$ $0$ $0$ $0$
shinytest2-tm_g_forest_rsp 💚 $176.68$ $-2.89$ $0$ $0$ $0$ $0$
shinytest2-tm_g_forest_tte 💚 $63.95$ $-1.17$ $0$ $0$ $0$ $0$
shinytest2-tm_g_km 💚 $271.16$ $-4.96$ $0$ $0$ $0$ $0$
shinytest2-tm_g_lineplot 💚 $88.69$ $-2.44$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_adverse_events 💚 $125.48$ $-1.44$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_patient_timeline 💚 $244.82$ $-3.43$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_therapy 💚 $198.24$ $-1.96$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_vitals 💚 $87.56$ $-2.05$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality 💚 $66.90$ $-1.65$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality_by_worst_grade 💚 $67.96$ $-1.44$ $0$ $0$ $0$ $0$
shinytest2-tm_t_ancova 💚 $95.91$ $-1.75$ $0$ $0$ $0$ $0$
shinytest2-tm_t_binary_outcome 💚 $77.25$ $-1.45$ $0$ $0$ $0$ $0$
shinytest2-tm_t_coxreg 💚 $73.81$ $-1.36$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events 💚 $61.66$ $-1.53$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_by_grade 💚 $91.24$ $-2.01$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_summary 💔 $60.53$ $+5.35$ $0$ $0$ $-11$ $0$
shinytest2-tm_t_exposure 💚 $80.47$ $-2.54$ $0$ $0$ $0$ $0$
shinytest2-tm_t_logistic 💚 $60.02$ $-1.03$ $0$ $0$ $0$ $0$
shinytest2-tm_t_mult_events 💚 $58.92$ $-1.99$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_basic_info 💔 $39.47$ $+1.79$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_laboratory 💚 $127.48$ $-3.25$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm_by_worst 💚 $90.69$ $-1.35$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_grade 💚 $80.27$ $-2.42$ $0$ $0$ $0$ $0$
shinytest2-tm_t_smq 💚 $59.85$ $-1.14$ $0$ $0$ $0$ $0$
shinytest2-tm_t_summary_by 💚 $80.22$ $-2.66$ $0$ $0$ $0$ $0$
shinytest2-tm_t_tte 💚 $67.04$ $-1.12$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-tm_a_mmrm 💚 $50.97$ $-1.08$ e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_t_mmrm_lsmeans.
shinytest2-tm_t_events_summary 💔 $7.42$ $+1.04$ e2e_tm_t_events_summary_Selecting_flag_var_aesi_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_t_events_summary 💔 $7.44$ $+1.02$ e2e_tm_t_events_summary_Selecting_flag_var_anl_changes_the_table_and_does_not_throw_validation_errors.

Results for commit 03c35c3

♻️ This comment has been updated with latest results.

@shajoezhu shajoezhu merged commit ed4809a into main Jan 17, 2025
29 checks passed
@shajoezhu shajoezhu deleted the shajoezhu-patch-1 branch January 17, 2025 16:06
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
@m7pr
Copy link
Contributor

m7pr commented Jan 20, 2025

ok thanks @shajoezhu

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants