113 adjust toggle_slider ranges

[m7pr]

This is solution for #133

toggle_slider is a component that is a sliderInput that can be toggled to become a numericInput.

The PR fixes the issue with ranges on sliderInput that should be adjusted based on numericInput.

So if slider had ranges min_sliderInput and max_sliderInput and values for numercInput are changed, so that min(numercInput) is lower than min_sliderInput or max(numercInput) is greater than max_sliderInput, then min_sliderInput or max_sliderInput should be extended for new ranges.

Example 1

min_sliderInput, max_sliderInput - on start 0, 55

hence numericInput on start 0, 55

numericInput changes to -5, 65

sliderInput changes to -5, 65

Example 2

Continuation of the previous one, if you change numericInput from -5, 65

to 4, 45

sliderInput is reset (the min and max) to original 0, 55 but values are set to 4, 45

[github-actions]

Code Coverage Summary

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  ---------
R/tm_g_gh_boxplot.R                        349     349  0.00%    175-591
R/tm_g_gh_correlationplot.R                554     554  0.00%    227-890
R/tm_g_gh_density_distribution_plot.R      276     276  0.00%    135-462
R/tm_g_gh_lineplot.R                       560     560  0.00%    161-815
R/tm_g_gh_scatterplot.R                    244     244  0.00%    144-440
R/tm_g_gh_spaghettiplot.R                  314     314  0.00%    194-590
R/toggleable_slider.R                      158     158  0.00%    73-248
R/utils-arbitrary_lines.r                  125     125  0.00%    19-176
R/utils-data_constraints.r                 190     190  0.00%    2-257
R/utils-keep_range_slider_updated.r         29      29  0.00%    9-45
R/utils-maptrt.r                             9       9  0.00%    24-36
R/utils-templ_ui.r                          66      66  0.00%    2-98
R/utils.R                                   49      49  0.00%    12-112
R/zzz.R                                      2       2  0.00%    2-3
TOTAL                                     2925    2925  0.00%

Diff against main

Filename                 Stmts    Miss  Cover
---------------------  -------  ------  --------
R/toggleable_slider.R       +4      +4  +100.00%
TOTAL                       +4      +4  +100.00%

Results for commit: a54d7f2

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[donyunardi]

I still see the same problem.

I used the example code that's provided in this comment and changed the "Select an X-Axis Biomarker" to "CRP".

Is it because the range is too short?

[m7pr]

I still see the same problem.

What problem do you see? I would assume you show the state of sliderInput and numericInput to describe the problem. Here you only posted sliderInput. What the user really wanted is to get sliderInput adjusted once numericInput get's changes and exceeds the limits of sliderInput

Screen.Recording.2024-10-08.094314.mp4

[m7pr]

Ah, ok I see. This issue is related to two things. The second thing are the ticks on slider that are non-unique. Will have a look at it as well

[donyunardi]

Looks good to me.
As discussed, we'll address the tick issue with a different PR.