-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add information about revisions to packages.json
#44
Comments
My worry here is that we are basically building a toml to json converter :P I am not against this but I wonder if the CI could look at Edit: This is slow but seems to do get you there already.
btw, I initially used toml because nix suports it natively, but then it tuned out that nix cannot read toml timestamps :-/ |
Well, that was what I was doing originally and then you made the metadata output and I thought I was supposed to do that :p also |
🤔 I guess one difference is who is using that information. If it's in CI we have the input metadata, so we don't really need anything else. If it's the end consumer (whoever is using cabal) they don't have access to the input metadata anymore, which is why we made package.sjon. |
At the moment there's a
timestamp
field, but that's the time the package version was added. It would be nice to know about revisions. I can see a few possible designs here:timestamp
tolast-modified
, and have it be the timestamp of the latest revision (or the original creation).timestamp
toadded
, and addrevised
as the timestamp of the latest revision.timestamp
toadded
, and addrevised
as a list of timestamps for the revisions.The reason I care is that the CHaP CI diffs the metadata to tell when packages have changed, so it knows what to build. At the moment it can only notice new package additions because revisions don't affect
packages.json
. Making them change it in any way would suffice for my purposes!The text was updated successfully, but these errors were encountered: