You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
But why use reflections for something we know already?
I mean, the package will always be placed inside the vendor path (this is always assumed to be used as a library), and reflections are not needed for a file to know which is the parent directory of a directory it belongs to.
And yes, the hardcoded '/../../../' isn't very elegant, but it works.
That said, @szepeviktor, you wrote that the method can be improved with your code, did you find any occurrence in which the current method failed? If so, it would be nice to know more about it.
Is your feature request related to a problem?
AssetPathResolver may improve with this method.
Describe the desired solution
Use the above method.
Describe the alternatives that you have considered
https://github.com/szepeviktor/package-path/blob/master/src/PackagePath.php#L38
Additional context
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: