Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Storybook Controls for Colors, Numbers, ... (for CSS Variables) #453

Open
janivo opened this issue Nov 4, 2021 · 0 comments · May be fixed by #1152
Open

Add Storybook Controls for Colors, Numbers, ... (for CSS Variables) #453

janivo opened this issue Nov 4, 2021 · 0 comments · May be fixed by #1152
Labels
feature This issue introduces a new feature
Milestone
Docs & Getting St...

Comments

@janivo
Copy link
Collaborator

janivo commented Nov 4, 2021 •
edited
Loading

It would be nice to be able to test all CSS-Vars we provided for each component in the corresponding storybook page.

  • Use custom matcher
  • Add color-pickers for CSS color variables
  • Add Number Input for size related properties
  • extract the name of the css vars from the config of the element
  • define a set of CssVarTypes (PxBased, Color) so that we only have to say which css has what type.
@janivo janivo added feature This issue introduces a new feature discussion This issue needs to be discussed further new This issue has been recently added and has no estimation labels Nov 4, 2021
@silentHoo silentHoo removed discussion This issue needs to be discussed further new This issue has been recently added and has no estimation labels Mar 15, 2022
@silentHoo silentHoo changed the title Stories for Custom-Properties (CSS-Vars) Add Storybook Controls for Colors, Numbers, ... (for CSS Variables) Mar 15, 2022
@pfecht pfecht mentioned this issue May 13, 2022
Merged
@janivo janivo removed the est-medium label May 24, 2022
@pfecht pfecht added this to the Docs & Getting Started milestone Jun 22, 2022
@iandi09 iandi09 self-assigned this Dec 29, 2023
@iandi09 iandi09 linked a pull request Dec 29, 2023 that will close this issue
Open
@iandi09 iandi09 removed their assignment Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature This issue introduces a new feature
Projects
None yet
Milestone
Docs & Getting Started
Development

Successfully merging a pull request may close this issue.

feat(storybook): added controls for CSS variables inovex/elements
4 participants
@silentHoo @iandi09 @janivo @pfecht