Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom strategy for handling invalid cookies #1

Open
cstettler opened this issue Jul 6, 2018 · 2 comments
Open

Allow custom strategy for handling invalid cookies #1

cstettler opened this issue Jul 6, 2018 · 2 comments
Assignees

Comments

@cstettler
Copy link
Member

Currently, if a cookie cannot be decoded due to an invalid signature, the flash manager implementation returns null:

In some cases, instead of simply ignoring the invalid cookie, a custom behaviour should be triggered (e.g. throwing an exception).

@mvitz
Copy link
Contributor

mvitz commented Jul 11, 2018

Thanks for your report.

I think this addition seems reasonable and I will try to include this.

mvitz added a commit that referenced this issue Jul 11, 2018
This feature allows to customize the behaviour of what should be done in
case the cookie could not be verified.

By default the cookie is silently ignored, as before.

Closes #1
@mvitz mvitz self-assigned this Jul 11, 2018
mvitz added a commit that referenced this issue Jul 11, 2018
This feature allows to customise the behaviour of what should be done in
case the cookie can not be verified.

By default the cookie is silently ignored, as before.

Closes #1
@mvitz
Copy link
Contributor

mvitz commented Jul 11, 2018

@cstettler I prepared this feature in #2. It would be nice if you could take a look and give some feedback.

mvitz added a commit that referenced this issue Nov 7, 2019
This feature allows to customise the behaviour of what should be done in
case the cookie can not be verified.

By default the cookie is silently ignored, as before.

Closes #1
mvitz added a commit that referenced this issue Apr 11, 2020
This feature allows to customise the behaviour of what should be done in
case the cookie can not be verified.

By default the cookie is silently ignored, as before.

Closes #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants