Add idempotency configuration #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertchae
requested review from
djfarrelly,
darwin67,
jpwilliams and
tonyhb
as code owners
albertchae
commented
Sep 9, 2024
| @@ -82,8 +82,11 @@ internal class InternalFunctionConfig | |||
| val throttle: Throttle? = null, | |||
| @Json(serializeNull = false) | |||
| val debounce: Debounce? = null, | |||
| @Json(serializeNull = false) | |||
There was a problem hiding this comment.
I missed this when resolving merge conflicts for #71
KiKoS0
approved these changes
Sep 9, 2024
Copied doc from https://github.com/inngest/inngest/blob/6594ccb692121bfe62b11676fe002416df13300b/docs/SDK_SPEC.md?plain=1#L534-L538 https://www.inngest.com/docs/guides/handling-idempotency#at-the-function-level-the-consumer The integration test validates idempotency by - checking an observable side effect, in this case incrementing a static counter variable - check that the second run of the same idempotency was ignored by the dev server
albertchae
force-pushed
the
albert/inn-3331-add-idempotency-configuration
branch
from
c025fbf
to
0bbeb8c
Compare
I thought I tried that (you'll notice I even named my test step |
albertchae
deleted the
albert/inn-3331-add-idempotency-configuration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
idempotencyas a top level optional string key to function configCopied doc from
https://github.com/inngest/inngest/blob/6594ccb692121bfe62b11676fe002416df13300b/docs/SDK_SPEC.md?plain=1#L534-L538
https://www.inngest.com/docs/guides/handling-idempotency#at-the-function-level-the-consumer
Ideally the integration test could use an observable side effect to seethat the function only ran once, but we are also able to use the return
value from the dev server to check that the second run was ignored.
The integration test validates idempotency by
Checklist
Related