Add SDK version in format java:v{version} to the sync call
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiKoS0
requested review from
djfarrelly,
darwin67,
jpwilliams and
tonyhb
as code owners
albertchae
approved these changes
Sep 8, 2024
There was a problem hiding this comment.
LGTM, we can change the language in a follow up if @djfarrelly decides to use a different string
| @@ -174,10 +174,10 @@ class CommHandler( | |||
| private fun getRegistrationRequestPayload(origin: String): RegistrationRequestPayload = | |||
| RegistrationRequestPayload( | |||
| appName = config.appId(), | |||
| framework = framework.toString(), | |||
| sdk = "inngest-kt", | |||
There was a problem hiding this comment.
interesting, I see the linear thread where you got java from. I feel like JVM or JRE is used in these situations but I can't think of a concrete example we can draw from
There was a problem hiding this comment.
yeah the runtime could be good too, same I know Sentry has both languages but the platform isn't auto-detected on there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add the SDK version to the sync request payload, assuming that we are going with
javaas the common denominator language : #76 (comment)Confirming that now the language shows up as Java and the version shows up correctly in cloud mode:
Changes:
vto0.1as mentioned in the spec.Checklist
Related