Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add priority configuration #71

Merged
merged 1 commit into from
Sep 6, 2024

Commits on Sep 6, 2024

  1. Add priority configuration

    `run` is marked as optional in the SDK spec and in the JS SDK, but this
    means we could call with an empty `priority` which seems a bit weird, so
    I made it required here.
    
    This seems difficult to write a reliable integration test and it looks
    like it was skipped in the other SDKs as well
    - inngest/inngest-py#114
    - inngest/inngest-js#362
    
    One possible test scenario we can try in a follow up, in combination
    with throttling
    - 2 functions, fun_2 is higher priority than fun_1, they are throttled on the same key
    - call fun_1, fun_1, fun_2 in that order
    - check after the first execution of fun_1, that fun_2 got executed next
      before the second execution of fun_2
    albertchae committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    5139c50 View commit details
    Browse the repository at this point in the history