Add priority configuration #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertchae
force-pushed
the
albert/inn-3334-priority-configuration
branch
from
11da0db
to
804932d
Compare
albertchae
requested review from
djfarrelly,
darwin67,
jpwilliams and
tonyhb
as code owners
|
Here's an example with priority test in the core repo. https://github.com/inngest/inngest/blob/main/tests/golang/priority_test.go |
darwin67
approved these changes
Sep 6, 2024
tonyhb
approved these changes
Sep 6, 2024
`run` is marked as optional in the SDK spec and in the JS SDK, but this means we could call with an empty `priority` which seems a bit weird, so I made it required here. This seems difficult to write a reliable integration test and it looks like it was skipped in the other SDKs as well - inngest/inngest-py#114 - inngest/inngest-js#362 One possible test scenario we can try in a follow up, in combination with throttling - 2 functions, fun_2 is higher priority than fun_1, they are throttled on the same key - call fun_1, fun_1, fun_2 in that order - check after the first execution of fun_1, that fun_2 got executed next before the second execution of fun_2
albertchae
force-pushed
the
albert/inn-3334-priority-configuration
branch
from
804932d
to
5139c50
Compare
cool I think we can try this. I'll merge PR as is and follow up with a test if it works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
runis marked as optional in the SDK spec and in the JS SDK, but thismeans we could call with an empty
prioritywhich seems a bit weird, soI made it required here.
This seems difficult to write a reliable integration test and it looks
like it was skipped in the other SDKs as well
priority.runconfig option inngest-js#362One possible test scenario we can try in a follow up, in combination
with throttling
before the second execution of fun_2
Checklist
Related