Implement debounce configuration #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertchae
force-pushed
the
albert/inn-3333-add-debounce-configuration
branch
from
b1d9daf
to
23b0d6a
Compare
albertchae
requested review from
djfarrelly,
darwin67,
jpwilliams and
tonyhb
as code owners
darwin67
approved these changes
Sep 6, 2024
tonyhb
approved these changes
Sep 6, 2024
Follows similar pattern to recently added `throttle` The integration test timing could lead to flakes but I tried to leave a generous buffer to minimize this without making the test too long. I wanted to add a second integration test for the debounce `timeout`, but configuring debounce with a `timeout` seems to result in the function never getting executed on the latest dev server (0.29.6). I verified this is true with the JS SDK as well.
albertchae
force-pushed
the
albert/inn-3333-add-debounce-configuration
branch
from
23b0d6a
to
8396fb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
debounceconfiguration, Follows similar pattern to recently addedthrottleThe integration test timing could lead to flakes but I tried to leave
a generous buffer to minimize this without making the test too long.
I wanted to add a second integration test for the debounce
timeout,but configuring debounce with a
timeoutseems to result in thefunction never getting executed on the latest dev server (0.29.6). I
verified this is true with the JS SDK as well.
Documentation for debounce mostly copied from JS SDK
Checklist
Related