Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INN-3321 - Config options builder #54

Merged
merged 13 commits into from
Jul 22, 2024
Merged

Conversation

djfarrelly
Copy link
Member

@djfarrelly djfarrelly commented Jul 18, 2024

See: INN-3321

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

ktlint

🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)

@Json(serializeNull = false) val event: String? = null,


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)

@Json(name = "expression", serializeNull = false) val `if`: String? = null,


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)

@Json(serializeNull = false) val cron: String? = null,


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line

val durationConverter = object : Converter {


🚫 [ktlint] standard:no-semi reported by reviewdog 🐶
Unnecessary semicolon

override fun canConvert(cls: Class<*>): Boolean = cls == Duration::class.java;


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)

@Json(serializeNull = false) val key: String? = null


🚫 [ktlint] standard:trailing-comma-on-declaration-site reported by reviewdog 🐶
Missing trailing comma before ")"

@Json(serializeNull = false) val key: String? = null


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

ktlint

🚫 [ktlint] standard:trailing-comma-on-declaration-site reported by reviewdog 🐶
Missing trailing comma before ")"

@Json(serializeNull = false) val key: String? = null


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)

@djfarrelly djfarrelly marked this pull request as ready for review July 18, 2024 17:14
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

ktlint

🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 28)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 24)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 24)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 28)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 28)

"url" to "$serveUrl?fnId=${id}&stepId=step",


🚫 [ktlint] standard:string-template reported by reviewdog 🐶
Redundant curly braces

"url" to "$serveUrl?fnId=${id}&stepId=step",


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 24)


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected after opening parenthesis

fun build(appId: String, serverUrl: String): InternalFunctionConfig {


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Parameter should start on a newline

fun build(appId: String, serverUrl: String): InternalFunctionConfig {


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected before closing parenthesis

fun build(appId: String, serverUrl: String): InternalFunctionConfig {


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line

val durationConverter = object : Converter {


🚫 [ktlint] standard:no-semi reported by reviewdog 🐶
Unnecessary semicolon

override fun canConvert(cls: Class<*>): Boolean = cls == Duration::class.java;


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)

@Json(serializeNull = false) val key: String? = null


🚫 [ktlint] standard:trailing-comma-on-declaration-site reported by reviewdog 🐶
Missing trailing comma before ")"

@Json(serializeNull = false) val key: String? = null


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)

@Json(serializeNull = false) val event: String? = null,


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)

@Json(serializeNull = false) val `if`: String? = null,


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)

@Json(serializeNull = false) val cron: String? = null,


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)


🚫 [ktlint] standard:no-empty-first-line-in-class-body reported by reviewdog 🐶
Class body should not start with blank line


🚫 [ktlint] standard:no-empty-class-body reported by reviewdog 🐶
Unnecessary block ("{}")

class Event(event: String, `if`: String? = null) : InngestFunctionTrigger(event, `if`, null) {}


🚫 [ktlint] standard:no-empty-class-body reported by reviewdog 🐶
Unnecessary block ("{}")

class Cron(cron: String) : InngestFunctionTrigger(null, null, cron) {}


🚫 [ktlint] standard:no-blank-line-before-rbrace reported by reviewdog 🐶
Unexpected blank line(s) before "}"

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

ktlint

🚫 [ktlint] standard:trailing-comma-on-declaration-site reported by reviewdog 🐶
Missing trailing comma before ")"

@Json(serializeNull = false) val key: String? = null


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)

@Json(serializeNull = false) val event: String? = null,


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)

@Json(serializeNull = false) val `if`: String? = null,


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)

@Json(serializeNull = false) val cron: String? = null,


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)

// IDEA - Add timeout and re-use for cancelOn?


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)


🚫 [ktlint] standard:no-empty-first-line-in-class-body reported by reviewdog 🐶
Class body should not start with blank line


🚫 [ktlint] standard:no-empty-class-body reported by reviewdog 🐶
Unnecessary block ("{}")

class Event(event: String, `if`: String? = null) : InngestFunctionTrigger(event, `if`, null) {}


🚫 [ktlint] standard:no-empty-class-body reported by reviewdog 🐶
Unnecessary block ("{}")

class Cron(cron: String) : InngestFunctionTrigger(null, null, cron) {}


🚫 [ktlint] standard:no-blank-line-before-rbrace reported by reviewdog 🐶
Unexpected blank line(s) before "}"

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

ktlint

🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected after opening parenthesis

fun concurrency(limit: Int, key: String? = null, scope: ConcurrencyScope? = null): InngestFunctionConfigBuilder {


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Parameter should start on a newline

fun concurrency(limit: Int, key: String? = null, scope: ConcurrencyScope? = null): InngestFunctionConfigBuilder {


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Parameter should start on a newline

fun concurrency(limit: Int, key: String? = null, scope: ConcurrencyScope? = null): InngestFunctionConfigBuilder {


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected before closing parenthesis

fun concurrency(limit: Int, key: String? = null, scope: ConcurrencyScope? = null): InngestFunctionConfigBuilder {


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 24)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 28)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 28)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 24)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 24)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 28)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 28)

"url" to "$serveUrl?fnId=${id}&stepId=step",


🚫 [ktlint] standard:string-template reported by reviewdog 🐶
Redundant curly braces

"url" to "$serveUrl?fnId=${id}&stepId=step",


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 24)


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected after opening parenthesis

internal fun build(appId: String, serverUrl: String): InternalFunctionConfig {


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Parameter should start on a newline

internal fun build(appId: String, serverUrl: String): InternalFunctionConfig {


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected before closing parenthesis

internal fun build(appId: String, serverUrl: String): InternalFunctionConfig {


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line

val durationConverter = object : Converter {


🚫 [ktlint] standard:no-semi reported by reviewdog 🐶
Unnecessary semicolon

override fun canConvert(cls: Class<*>): Boolean = cls == Duration::class.java;


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line

val concurrencyScopeConverter = object : Converter {


🚫 [ktlint] standard:blank-line-before-declaration reported by reviewdog 🐶
Expected a blank line for this declaration

override fun fromJson(jv: JsonValue): ConcurrencyScope = enumValueOf<ConcurrencyScope>(jv.string!!)


🚫 [ktlint] standard:blank-line-before-declaration reported by reviewdog 🐶
Expected a blank line for this declaration

override fun toJson(value: Any): String = """"${(value as ConcurrencyScope).value}""""


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)

@Json(serializeNull = false) val key: String? = null


🚫 [ktlint] standard:trailing-comma-on-declaration-site reported by reviewdog 🐶
Missing trailing comma before ")"

@Json(serializeNull = false) val key: String? = null


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)

@Json(serializeNull = false) val event: String? = null,


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)

@Json(serializeNull = false) val `if`: String? = null,


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)

@Json(serializeNull = false) val cron: String? = null,


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)

// IDEA - Add timeout and re-use for cancelOn?


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)


🚫 [ktlint] standard:no-empty-first-line-in-class-body reported by reviewdog 🐶
Class body should not start with blank line


🚫 [ktlint] standard:no-empty-class-body reported by reviewdog 🐶
Unnecessary block ("{}")

class Event(event: String, `if`: String? = null) : InngestFunctionTrigger(event, `if`, null) {}


🚫 [ktlint] standard:no-empty-class-body reported by reviewdog 🐶
Unnecessary block ("{}")

class Cron(cron: String) : InngestFunctionTrigger(null, null, cron) {}


🚫 [ktlint] standard:no-blank-line-before-rbrace reported by reviewdog 🐶
Unexpected blank line(s) before "}"

@djfarrelly djfarrelly changed the title Config options builder INN-3321 - Config options builder Jul 22, 2024
Copy link

linear bot commented Jul 22, 2024

@djfarrelly djfarrelly merged commit 6d13104 into main Jul 22, 2024
9 checks passed
@djfarrelly djfarrelly deleted the task/config-options-builder branch July 22, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant