-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INN-3321 - Config options builder #54
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
ktlint
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)
@JvmOverloads |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)
constructor( |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)
@Json(serializeNull = false) val event: String? = null, |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)
@Json(name = "expression", serializeNull = false) val `if`: String? = null, |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)
@Json(serializeNull = false) val cron: String? = null, |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)
🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line
val durationConverter = object : Converter { |
🚫 [ktlint] standard:no-semi reported by reviewdog 🐶
Unnecessary semicolon
override fun canConvert(cls: Class<*>): Boolean = cls == Duration::class.java; |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)
@JvmOverloads |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)
constructor( |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)
val maxSize: Int, |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)
@KlaxonDuration |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)
val timeout: Duration, |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)
@Json(serializeNull = false) val key: String? = null |
🚫 [ktlint] standard:trailing-comma-on-declaration-site reported by reviewdog 🐶
Missing trailing comma before ")"
@Json(serializeNull = false) val key: String? = null |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
ktlint
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 28)
"attempts" to 3, |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 24)
), |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 24)
hashMapOf( |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 28)
"type" to scheme, |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 28)
"url" to "$serveUrl?fnId=${id}&stepId=step", |
🚫 [ktlint] standard:string-template reported by reviewdog 🐶
Redundant curly braces
"url" to "$serveUrl?fnId=${id}&stepId=step", |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 24)
), |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected after opening parenthesis
fun build(appId: String, serverUrl: String): InternalFunctionConfig { |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Parameter should start on a newline
fun build(appId: String, serverUrl: String): InternalFunctionConfig { |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected before closing parenthesis
fun build(appId: String, serverUrl: String): InternalFunctionConfig { |
🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line
val config = InternalFunctionConfig( |
🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"
steps = buildSteps(serverUrl) |
🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line
val durationConverter = object : Converter { |
🚫 [ktlint] standard:no-semi reported by reviewdog 🐶
Unnecessary semicolon
override fun canConvert(cls: Class<*>): Boolean = cls == Duration::class.java; |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)
@JvmOverloads |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)
constructor( |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)
val maxSize: Int, |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)
@KlaxonDuration |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)
val timeout: Duration, |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)
@Json(serializeNull = false) val key: String? = null |
🚫 [ktlint] standard:trailing-comma-on-declaration-site reported by reviewdog 🐶
Missing trailing comma before ")"
@Json(serializeNull = false) val key: String? = null |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)
) |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)
@JvmOverloads |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)
constructor( |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)
@Json(serializeNull = false) val event: String? = null, |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)
@Json(serializeNull = false) val `if`: String? = null, |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)
@Json(serializeNull = false) val cron: String? = null, |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)
🚫 [ktlint] standard:no-empty-first-line-in-class-body reported by reviewdog 🐶
Class body should not start with blank line
🚫 [ktlint] standard:no-empty-class-body reported by reviewdog 🐶
Unnecessary block ("{}")
class Event(event: String, `if`: String? = null) : InngestFunctionTrigger(event, `if`, null) {} |
🚫 [ktlint] standard:no-empty-class-body reported by reviewdog 🐶
Unnecessary block ("{}")
class Cron(cron: String) : InngestFunctionTrigger(null, null, cron) {} |
🚫 [ktlint] standard:no-blank-line-before-rbrace reported by reviewdog 🐶
Unexpected blank line(s) before "}"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
ktlint
🚫 [ktlint] standard:trailing-comma-on-declaration-site reported by reviewdog 🐶
Missing trailing comma before ")"
@Json(serializeNull = false) val key: String? = null |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)
) |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)
@JvmOverloads |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)
constructor( |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)
@Json(serializeNull = false) val event: String? = null, |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)
@Json(serializeNull = false) val `if`: String? = null, |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)
@Json(serializeNull = false) val cron: String? = null, |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)
// IDEA - Add timeout and re-use for cancelOn? |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)
🚫 [ktlint] standard:no-empty-first-line-in-class-body reported by reviewdog 🐶
Class body should not start with blank line
🚫 [ktlint] standard:no-empty-class-body reported by reviewdog 🐶
Unnecessary block ("{}")
class Event(event: String, `if`: String? = null) : InngestFunctionTrigger(event, `if`, null) {} |
🚫 [ktlint] standard:no-empty-class-body reported by reviewdog 🐶
Unnecessary block ("{}")
class Cron(cron: String) : InngestFunctionTrigger(null, null, cron) {} |
🚫 [ktlint] standard:no-blank-line-before-rbrace reported by reviewdog 🐶
Unexpected blank line(s) before "}"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
ktlint
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected after opening parenthesis
fun concurrency(limit: Int, key: String? = null, scope: ConcurrencyScope? = null): InngestFunctionConfigBuilder { |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Parameter should start on a newline
fun concurrency(limit: Int, key: String? = null, scope: ConcurrencyScope? = null): InngestFunctionConfigBuilder { |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Parameter should start on a newline
fun concurrency(limit: Int, key: String? = null, scope: ConcurrencyScope? = null): InngestFunctionConfigBuilder { |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected before closing parenthesis
fun concurrency(limit: Int, key: String? = null, scope: ConcurrencyScope? = null): InngestFunctionConfigBuilder { |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 24)
mapOf( |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 28)
// TODO - Pull from conf option |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 28)
"attempts" to 3, |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 24)
), |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 24)
hashMapOf( |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 28)
"type" to scheme, |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 28)
"url" to "$serveUrl?fnId=${id}&stepId=step", |
🚫 [ktlint] standard:string-template reported by reviewdog 🐶
Redundant curly braces
"url" to "$serveUrl?fnId=${id}&stepId=step", |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 24)
), |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected after opening parenthesis
internal fun build(appId: String, serverUrl: String): InternalFunctionConfig { |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Parameter should start on a newline
internal fun build(appId: String, serverUrl: String): InternalFunctionConfig { |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected before closing parenthesis
internal fun build(appId: String, serverUrl: String): InternalFunctionConfig { |
🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line
val config = InternalFunctionConfig( |
🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"
steps = buildSteps(serverUrl) |
🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line
val durationConverter = object : Converter { |
🚫 [ktlint] standard:no-semi reported by reviewdog 🐶
Unnecessary semicolon
override fun canConvert(cls: Class<*>): Boolean = cls == Duration::class.java; |
🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line
val concurrencyScopeConverter = object : Converter { |
🚫 [ktlint] standard:blank-line-before-declaration reported by reviewdog 🐶
Expected a blank line for this declaration
override fun fromJson(jv: JsonValue): ConcurrencyScope = enumValueOf<ConcurrencyScope>(jv.string!!) |
🚫 [ktlint] standard:blank-line-before-declaration reported by reviewdog 🐶
Expected a blank line for this declaration
override fun toJson(value: Any): String = """"${(value as ConcurrencyScope).value}"""" |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)
@JvmOverloads |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)
constructor( |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)
val limit: Int, |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)
@Json(serializeNull = false) |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)
val key: String? = null, |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)
@Json(serializeNull = false) |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)
@KlaxonConcurrencyScope |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)
val scope: ConcurrencyScope? = null, |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)
) |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)
@JvmOverloads |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)
constructor( |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)
val maxSize: Int, |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)
@KlaxonDuration |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)
val timeout: Duration, |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)
@Json(serializeNull = false) val key: String? = null |
🚫 [ktlint] standard:trailing-comma-on-declaration-site reported by reviewdog 🐶
Missing trailing comma before ")"
@Json(serializeNull = false) val key: String? = null |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)
) |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)
@JvmOverloads |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)
constructor( |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)
@Json(serializeNull = false) val event: String? = null, |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)
@Json(serializeNull = false) val `if`: String? = null, |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)
@Json(serializeNull = false) val cron: String? = null, |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (4) (should be 8)
// IDEA - Add timeout and re-use for cancelOn? |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (0) (should be 4)
🚫 [ktlint] standard:no-empty-first-line-in-class-body reported by reviewdog 🐶
Class body should not start with blank line
🚫 [ktlint] standard:no-empty-class-body reported by reviewdog 🐶
Unnecessary block ("{}")
class Event(event: String, `if`: String? = null) : InngestFunctionTrigger(event, `if`, null) {} |
🚫 [ktlint] standard:no-empty-class-body reported by reviewdog 🐶
Unnecessary block ("{}")
class Cron(cron: String) : InngestFunctionTrigger(null, null, cron) {} |
🚫 [ktlint] standard:no-blank-line-before-rbrace reported by reviewdog 🐶
Unexpected blank line(s) before "}"
See: INN-3321