Fix serialization of Java objects in step results/errors #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiKoS0
force-pushed
the
fix-deserialization
branch
from
324e24e
to
8d8c03c
Compare
KiKoS0
changed the title
KiKoS0
changed the title
KiKoS0
requested review from
djfarrelly,
darwin67,
jpwilliams and
tonyhb
as code owners
albertchae
approved these changes
Feb 28, 2024
Step/Function result classes are no longer required to be public with strictly public properties to serialize correctly when sending response payloads to Inngest.
KiKoS0
force-pushed
the
fix-deserialization
branch
from
8d8c03c
to
c87ceeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces Klaxon with jackson's
ObjectMapperfor serializingcallFunctionresponses. Which means it's no longer required to have step/function results to be public classes with public properties only. That requirement was introduced here: #19 (comment).Ideally I think we want to use jackson as much as possible eventually removing klaxon since it's not Java friendly.