Address PR feedback

inngest · Sep 13, 2024 · 4f9b4b9 · 4f9b4b9
1 parent c2804ef
commit 4f9b4b9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/inngest-spring-boot-adapter/src/main/java/com/inngest/springboot/InngestController.java b/inngest-spring-boot-adapter/src/main/java/com/inngest/springboot/InngestController.java
@@ -31,7 +31,6 @@ private HttpHeaders getHeaders() {
     @GetMapping
     public ResponseEntity<String> index(
         @RequestHeader(HttpHeaders.HOST) String hostHeader,
-        HttpServletRequest request,
         @RequestHeader(name = "X-Inngest-Signature", required = false) String signature,
         @RequestHeader(name = "X-Inngest-Server-Kind", required = false) String serverKind
     ) {

diff --git a/inngest/src/main/kotlin/com/inngest/ServeConfig.kt b/inngest/src/main/kotlin/com/inngest/ServeConfig.kt
@@ -33,7 +33,13 @@ class ServeConfig
             }
         }
 
-        fun hasSigningKey() = signingKey() !in listOf(DUMMY_SIGNING_KEY, "")
+        fun hasSigningKey() {
+            when (signingKey()) {
+                DUMMY_SIGNING_KEY -> false
+                "" -> false
+                else -> true
+            }
+        }
 
         fun baseUrl(): String {
             if (baseUrl != null) return baseUrl