Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove interfaces.py (RFC) #47

Open
krenzlin opened this issue May 15, 2020 · 2 comments
Open

remove interfaces.py (RFC) #47

krenzlin opened this issue May 15, 2020 · 2 comments

Comments

@krenzlin
Copy link
Contributor

interfaces.py declares interfaces (i.e. classes) which are meant to be used in the server part of pyoai.

There are some issues

  1. All methods are missing the self argument
  2. Interfaces in itself are not pythonic.
  3. There are mixins in common.py which seem to serve the same idea.

While the interfaces are broken, they still have value as documentation and example for a server implementation.

My proposal is to move the comments from interfaces to the common mixins, maybe adding default implementations where its sensible and remove interfaces.py

@kmccurley
Copy link

I'm guessing that this project is abandoned.

@wetneb
Copy link
Collaborator

wetneb commented Apr 23, 2022

I am happy to merge and deploy sensible fixes @kmccurley (but if you do not depend on this library yet, please use something else, it has indeed many issues)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants