You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
interfaces.py declares interfaces (i.e. classes) which are meant to be used in the server part of pyoai.
There are some issues
All methods are missing the self argument
Interfaces in itself are not pythonic.
There are mixins in common.py which seem to serve the same idea.
While the interfaces are broken, they still have value as documentation and example for a server implementation.
My proposal is to move the comments from interfaces to the common mixins, maybe adding default implementations where its sensible and remove interfaces.py
The text was updated successfully, but these errors were encountered:
I am happy to merge and deploy sensible fixes @kmccurley (but if you do not depend on this library yet, please use something else, it has indeed many issues)
interfaces.py
declares interfaces (i.e. classes) which are meant to be used in the server part ofpyoai
.There are some issues
self
argumentcommon.py
which seem to serve the same idea.While the interfaces are broken, they still have value as documentation and example for a server implementation.
My proposal is to move the comments from
interfaces
to thecommon
mixins, maybe adding default implementations where its sensible and removeinterfaces.py
The text was updated successfully, but these errors were encountered: