Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WS Subscription Events Silently Dropped on Parse Error #1399

Open
ryanrossiter opened this issue Mar 16, 2024 · 1 comment
Open

WS Subscription Events Silently Dropped on Parse Error #1399

ryanrossiter opened this issue Mar 16, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ryanrossiter
Copy link

What went wrong?

When using the WebSocketClient to subscribe to events, if the event cannot be parsed into a JSON RPC event due to a deserialization error, the event is silently ignored. This is then difficult to debug why events aren't being received.

Steps to reproduce

Subscribe to a TM 37 chain using the TM 34 compatibilty mode, which will cause event parsing to fail since the events won't be decodable from base64.

Definition of "done"

Event parsing errors should be relayed to the subscriber to handle.

@ryanrossiter ryanrossiter added the bug Something isn't working label Mar 16, 2024
@romac
Copy link
Member

romac commented Mar 18, 2024

Agreed, we should indeed forward such errors to subscribers. Would you be willing to open a PR to address this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants