-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p2p: failure to read complete message #1392
Comments
This might be related to #1356, although curiously people claim things work with Unix domain sockets and the errors only occur over TCP. I did confirm |
We're continuing to receive reports of this problem even with |
There's now a PR to tmkms to have it aggregate chunks of data itself and keep trying to decode them as a proto: iqlusioninc/tmkms#903 ...and it really seems like |
What went wrong?
There are ongoing reports of failure to read a complete message in the
tendermint-p2p
crate which seem to be manifesting as an incomplete Protobuf message in TMKMS:iqlusioninc/tmkms#729
Steps to reproduce
Unfortunately this seems very chain-specific and I have not been given proper repro steps myself in the aforementioned issue.
Definition of "done"
It's unclear what actually needs to change here.
A somewhat related issue is the API that
tendermint-p2p
exposes: it's a message-oriented protocol, but the interface uses thestd::io::{Read, Write}
traits, which are stream-oriented. It's possible TMKMS is misusing the API, but it's the wrong abstraction to begin with.The text was updated successfully, but these errors were encountered: