Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement suggestions to the conclude module #2017

Open
3 of 7 tasks
seanchen1991 opened this issue Mar 25, 2022 · 2 comments
Open
3 of 7 tasks

Improvement suggestions to the conclude module #2017

seanchen1991 opened this issue Mar 25, 2022 · 2 comments
Assignees

Comments

@seanchen1991
Copy link
Contributor

Summary

Some suggestions for improvements to the conclude.rs module, notably adding colors to the status types (red for Error, green for Success, etc.) as well as adding an Info status type.

Problem Definition

While working on #2014, I found myself wanting to output terminal output that didn't fit neatly into either Success or Error status types. These would have been appropriate being displayed via something like Output::info. Would it be appropriate to add this as a status type?

Additionally, it would be nice to add colors to the terminal output, i.e. red for Error output and green for Success output (Info would be colored blue) in order to match the colors that the logs exhibit. This can be easily done with the console crate.

Proposal

Add an Info status type to the conclude module, as well as add color styling to the status types.

Acceptance Criteria

  • Add Info status type
  • Add color styling to status types

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@seanchen1991 seanchen1991 self-assigned this Mar 25, 2022
@seanchen1991
Copy link
Contributor Author

Pinging @mzabaluev in particular as the author of the conclude module.

@mzabaluev
Copy link
Contributor

@seanchen1991 I should take a look, but note that I'm not the author of the majority of the code.

@adizere adizere added this to the v2 milestone Jul 26, 2022
@seanchen1991 seanchen1991 removed this from the v2 milestone Dec 22, 2022
@seanchen1991 seanchen1991 moved this to 🩹 Triage in Hermes Dec 22, 2022
@seanchen1991 seanchen1991 moved this from 🩹 Triage to 📋 Backlog in Hermes Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants