Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

knife cluster launch "Computers are running" warning returns non-zero exit code #343

Open
davidsnyder opened this issue Feb 24, 2014 · 1 comment
Open

knife cluster launch "Computers are running" warning returns non-zero exit code #343

davidsnyder opened this issue Feb 24, 2014 · 1 comment

Comments

@davidsnyder
Copy link

Running knife cluster launch a second time after having successfully brought up a machine gives:

WARNING:
WARNING: All computers are running -- not launching any.
WARNING:

and exits non-zero:

echo $?
1

This seems worth a warning, but to not exit cleanly feels wrong. The machine /is/ launched after all. If I'm running a build in CI I'd like it to be idempotent from run to run if the machine is already up and not break the second time.
@joshbronson
Copy link
Contributor

https://review.infochimps.com/#/c/80/

joshbronson added a commit that referenced this issue Feb 25, 2014
@joshbronson
feature: cleaner cluster launch exit status
af299f9 
exiting with 0 status instead of 1 when launching a cluster that is
already launched.

This addresses #343

Squashed commit of the following:

commit d84cd17869759aded212ba9e2ee57332a533958b
Author: Josh Bronson <[email protected]>
Date:   Mon Feb 24 17:38:54 2014 -0600

    Version bump to 5.0.10

    Change-Id: I01622f2880d61aca0d7d2c4b06bf29df161fec89

commit c23ef64934efbeab0219a74ca8b931c7671e315e
Author: Josh Bronson <[email protected]>
Date:   Mon Feb 24 17:38:37 2014 -0600

    exit status 0 instead of 1 when machines already launched

    Change-Id: I1a85c4c8f7d35fad9f56cf556fe5b0b7b9dbbe96

Change-Id: I0556717172cc8836ead1976e1b1b52e260f197b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidsnyder @joshbronson