Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disclaimer content is the same for WPML & Cloudflare #356

Open
piqusy opened this issue Jan 15, 2024 · 0 comments · Fixed by #427
Open

Disclaimer content is the same for WPML & Cloudflare #356

piqusy opened this issue Jan 15, 2024 · 0 comments · Fixed by #427
Assignees
@iruzevic
Labels
bug Something isn't working

Comments

@piqusy
Copy link
Contributor

piqusy commented Jan 15, 2024

eightshift-forms/src/Misc/SettingsCloudflare.php

Line 86 in 81a2bec

$this->getIntroOutput(self::SETTINGS_TYPE_KEY),

The method returns the same content:

Eightshift Forms doesn't configure the Wpml app or any other third-party tools. However, enabling this feature adds necessary configurations in the backend for everything to function correctly.

Updating the disclaimer to something more generic would be good enough IMO.
@piqusy piqusy added the bug Something isn't working label Jan 15, 2024
@iruzevic iruzevic linked a pull request Jun 4, 2024 that will close this issue
Feature/cache #427
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iruzevic iruzevic

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/cache infinum/eightshift-forms
2 participants
@piqusy @iruzevic