Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contribution/docs template to require testing new/changed app features #2786

Open
fpena opened this issue Sep 25, 2024 · 2 comments
Open

Update contribution/docs template to require testing new/changed app features #2786

fpena opened this issue Sep 25, 2024 · 2 comments
Assignees
@fpena
Labels
enhancement

Comments

@fpena
Copy link
Collaborator

fpena commented Sep 25, 2024 •
edited
Loading

This can be:

  • Another checklist item in the PR template
  • Add screenshots if the feature is visible
@fpena fpena changed the title Add to contribution docs a note to test a feature if this one is been replaced in a PR Update contribution/docs template to require testing new/changed app features Sep 25, 2024
@lindboe
Copy link
Contributor

lindboe commented Sep 25, 2024

idea: one way to encourage contributors to test is to add a section to the PR template to request screenshots if the changes are visible in the app

@frankcalise
Copy link
Contributor

I would clarify screenshots to be screenshots or video of both "before" and "after" so it's easy for the reviewer to see the difference

@fpena fpena self-assigned this Oct 1, 2024
@fpena fpena mentioned this issue Oct 1, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fpena fpena

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@frankcalise @fpena @lindboe