Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot run project on Android 8.0 #2719

Open
janwiebe-jump opened this issue Jul 31, 2024 · 2 comments
Open

Cannot run project on Android 8.0 #2719

janwiebe-jump opened this issue Jul 31, 2024 · 2 comments
Labels

Comments

@janwiebe-jump
Copy link
Contributor

Describe the bug

The app crashes immediately with an IllegalStateException:
Only fullscreen opaque activities can request orientation

This is caused by the portrait in the Android Manifest, that is set in the app.json:

See: https://stackoverflow.com/questions/48072438/java-lang-illegalstateexception-only-fullscreen-opaque-activities-can-request-o for reference.

Removing the orientation from the app.json solves this issue.

Ignite version

7.15.0

Additional info

just regular

@lindboe
Copy link
Contributor

lindboe commented Aug 1, 2024

Hi, thanks for the report!

I think this is a bug with Expo: app.json is an Expo tool, and Expo does say Android 6+ should be supported: https://docs.expo.dev/versions/latest/config/app/#orientation.

That said, I don't think we're likely to remove the orientation configuration in order to support Android 8; older Android support isn't often a priority for us. Maybe we should raise the minSdkVersion in the template instead. @frankcalise do you have thoughts on this?

@frankcalise
Copy link
Contributor

@lindboe Agree, if this is just configuration needed for a specific project, then it should just be that. Maybe a discussion thread or recipe page on better support for Android 8.0?

But looking at that stack overflow, is it possible to address such an issue with a specific version of styles.xml? Because we do have a config plugin setting windowIsTranslucent to address an Android 12 issue.

image

So maybe we can achieve this with a more tailored plugin?

https://github.com/infinitered/ignite/blob/master/boilerplate/plugins/withSplashScreen.ts#L62-L74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants