Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ctrl+c doesn't successfully stop deployment #5

Open
lovesegfault opened this issue May 29, 2020 · 2 comments · May be fixed by #36
Open

ctrl+c doesn't successfully stop deployment #5

lovesegfault opened this issue May 29, 2020 · 2 comments · May be fixed by #36

Comments

@lovesegfault
Copy link
Contributor

When executing the deployment script ctrl+c is moot as it will just continue to go non-stop
@infinisil
Copy link
Owner

Yeah this is rather annoying, I'm hoping that I can use Haskell instead of bash in the future, so I don't need to mess with bash's process handling (which is a nightmare imo)

@infinisil infinisil mentioned this issue Jul 21, 2020
Merged
@bqv
Copy link
Contributor

bqv commented Aug 13, 2020

I think a strength of this is that it doesn't require any extra binaries than nix and a shell, but I do like haskell so I won't complain

bjornfor added a commit to bjornfor/nixus that referenced this issue Nov 1, 2020
@bjornfor
Make the deploy script kill child processes upon exit
b074b81 
This allows aborting the deploy with Ctrl-C.

Fixes infinisil#5.
@bjornfor bjornfor linked a pull request Nov 1, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the deploy script kill child processes upon exit bjornfor/nixus
3 participants
@bqv @lovesegfault @infinisil