From 54138a37a0b353ec8bbac2474095ad18599e6c0f Mon Sep 17 00:00:00 2001 From: Joshua Bell Date: Tue, 19 Dec 2023 10:32:06 -0800 Subject: [PATCH] Conventions: Use more specific names than key/value in map iteration E.g. if the key is a name, use |name| For #450 --- index.bs | 58 ++++++++++++++++++++++++++++---------------------------- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/index.bs b/index.bs index 2cdd483e..9763b51b 100644 --- a/index.bs +++ b/index.bs @@ -992,21 +992,21 @@ partial interface MLCommandEncoder {
1. If any of the following requirements are unmet, then [=exception/throw=] a "{{DataError}}" {{DOMException}}.
- 1. [=map/For each=] |key| → |value| of |inputs|: - 1. |graph|.{{MLGraph/[[inputDescriptors]]}}[|key|] must [=map/exist=]. - 1. Let |inputDesc| be |graph|.{{MLGraph/[[inputDescriptors]]}}[|key|]. - 1. If |value| is a {{GPUBuffer}}, then: - 1. |value|.{{GPUBuffer/size}} must equal to [=byte length=] of |inputDesc|. - 1. [=map/For each=] |key| → |value| of |outputs|: - 1. |graph|.{{MLGraph/[[outputDescriptors]]}}[|key|] must [=map/exist=]. - 1. Let |outputDesc| be |graph|.{{MLGraph/[[outputDescriptors]]}}[|key|]. - 1. If |value| is a {{GPUBuffer}}, then: - 1. |value|.{{GPUBuffer/size}} must equal to [=byte length=] of |outputDesc|. + 1. [=map/For each=] |name| → |input| of |inputs|: + 1. |graph|.{{MLGraph/[[inputDescriptors]]}}[|name|] must [=map/exist=]. + 1. Let |inputDesc| be |graph|.{{MLGraph/[[inputDescriptors]]}}[|name|]. + 1. If |input| is a {{GPUBuffer}}, then: + 1. |input|.{{GPUBuffer/size}} must equal to [=byte length=] of |inputDesc|. + 1. [=map/For each=] |name| → |output| of |outputs|: + 1. |graph|.{{MLGraph/[[outputDescriptors]]}}[|name|] must [=map/exist=]. + 1. Let |outputDesc| be |graph|.{{MLGraph/[[outputDescriptors]]}}[|name|]. + 1. If |output| is a {{GPUBuffer}}, then: + 1. |output|.{{GPUBuffer/size}} must equal to [=byte length=] of |outputDesc|.
- 1. [=map/For each=] |key| → |value| of |inputs|: - 1. Set the input of |graph|.{{MLGraph/[[implementation]]}} that is associated with |key| to |value|. - 1. [=map/For each=] |key| → |value| of |outputs|: - 1. Set the output of |graph|.{{MLGraph/[[implementation]]}} that is associated with |key| to |value|. + 1. [=map/For each=] |name| → |input| of |inputs|: + 1. Set the input of |graph|.{{MLGraph/[[implementation]]}} that is associated with |name| to |input|. + 1. [=map/For each=] |name| → |output| of |outputs|: + 1. Set the output of |graph|.{{MLGraph/[[implementation]]}} that is associated with |name| to |output|. 1. Issue a compute request of |graph|.{{MLGraph/[[implementation]]}}. 1. If there is an error returned by |graph|.{{MLGraph/[[implementation]]}}, then: 1. Throw an "{{OperationError}}" {{DOMException}}. @@ -1153,9 +1153,9 @@ partial interface MLContext { To validate graph resources, given |resources| and |descriptors|, run the following steps:
- 1. [=map/For each=] |key| → |value| of |resources|: - 1. If |descriptors|[|key|] does not [=map/exist=], return false. - 1. If validating buffer with descriptor given |value| and |descriptors|[|key|] returns false, then return false. + 1. [=map/For each=] |name| → |resource| of |resources|: + 1. If |descriptors|[|name|] does not [=map/exist=], return false. + 1. If validating buffer with descriptor given |resource| and |descriptors|[|name|] returns false, then return false. 1. Return true.
@@ -1177,18 +1177,18 @@ partial interface MLContext {
1. Let |inputResources| denote the input resources of |graph|.{{MLGraph/[[implementation]]}}. - 1. [=map/For each=] |key| → |inputValue| of |inputs|: - 1. Let |inputDescriptor| be |graph|.{{MLGraph/[[inputDescriptors]]}}[|key|]. + 1. [=map/For each=] |name| → |inputValue| of |inputs|: + 1. Let |inputDescriptor| be |graph|.{{MLGraph/[[inputDescriptors]]}}[|name|]. 1. Let |inputTensor| be a new tensor for |graph|.{{MLGraph/[[implementation]]}} as follows: 1. Set the data type of |inputTensor| to the one that matches the [=element type=] of |inputValue|. 1. Set the dimensions of |inputTensor| to |inputDescriptor|.{{MLOperandDescriptor/dimensions}}. 1. Set the values of elements in |inputTensor| to the values of elements in |inputValue|. - 1. Request the underlying implementation of |graph| to bind |inputResources|[|key|] to |inputTensor|. - 1. [=map/For each=] |key| → |outputValue| of |outputs|: - 1. Issue a compute request to |graph|.{{MLGraph/[[implementation]]}} given |key| and |inputResources| and wait for completion. + 1. Request the underlying implementation of |graph| to bind |inputResources|[|name|] to |inputTensor|. + 1. [=map/For each=] |name| → |outputValue| of |outputs|: + 1. Issue a compute request to |graph|.{{MLGraph/[[implementation]]}} given |name| and |inputResources| and wait for completion. 1. If that returns an error, then [=exception/throw=] an "{{OperationError}}" {{DOMException}}. 1. Otherwise, store the result in |outputTensor|. - 1. Let |outputDesc| be |graph|.{{MLGraph/[[outputDescriptors]]}}[|key|]. + 1. Let |outputDesc| be |graph|.{{MLGraph/[[outputDescriptors]]}}[|name|]. 1. If the byte length of |outputTensor| is not equal to the [=byte length=] of |outputDesc|, then [=exception/throw=] a "{{DataError}}" {{DOMException}}. 1. If the [=element type=] of |outputTensor| doesn't match the [=element type=] of |outputValue|, then [=exception/throw=] a "{{DataError}}" {{DOMException}}. 1. Request the underlying implementation of |graph| to set the values of elements in |outputValue| to the values of elements in |outputTensor|. @@ -1244,12 +1244,12 @@ partial interface MLContext {
1. Let |transferredViews| be a new {{MLNamedArrayBufferViews}}. - 1. [=map/For each=] |key| → |value| of |views|: - 1. Let |transferredBuffer| be the result of [=ArrayBuffer/transfer|transferring=] the [=underlying buffer=] of |value|. - 1. Let |constructor| be the appropriate [=view constructor=] for the type of {{ArrayBufferView}} |value|. - 1. Let |elementsNumber| be the result of the [=BufferSource/byte length=] of |value| ÷ [=element size=] of |value|. - 1. Let |transferredView| be [$Construct$](|constructor|, |transferredBuffer|, |value|.\[[ByteOffset]], |elementsNumber|). - 1. Set |transferredViews|[|key|] to |transferredView|. + 1. [=map/For each=] |name| → |view| of |views|: + 1. Let |transferredBuffer| be the result of [=ArrayBuffer/transfer|transferring=] the [=underlying buffer=] of |view|. + 1. Let |constructor| be the appropriate [=view constructor=] for the type of {{ArrayBufferView}} |view|. + 1. Let |elementsNumber| be the result of the [=BufferSource/byte length=] of |view| ÷ [=element size=] of |view|. + 1. Let |transferredView| be [$Construct$](|constructor|, |transferredBuffer|, |view|.\[[ByteOffset]], |elementsNumber|). + 1. Set |transferredViews|[|name|] to |transferredView|. 1. Return |transferredViews|.