Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Android APKs as Github releases as a part of Fastlane deployment #647

Open
DiagonalArg opened this issue Oct 30, 2023 · 5 comments
Labels
enhancement New feature or request Seek

Comments

@DiagonalArg
Copy link

Like @kasbah , who was asking about a non-google fallback for location services, I am running a non-google phone (GrapheneOS). I see that iNaturalist itself makes .apk's available. Would Seek consider the same?

@kasbah
Copy link

kasbah commented Oct 30, 2023

Adding to F-Droid would also be nice.

@DiagonalArg
Copy link
Author

Adding to F-Droid would also be nice.

O/T, but f-droid signs the packages themselves. I think better to use obtainium with the developer signed packages from github.

@kueda kueda added the enhancement New feature or request label Oct 31, 2023
@kueda kueda changed the title iNaturalist has .apk's available for non-google phones. Would Seek consider the same? Publish Android APKs as Github releases as a part of Fastlane deployment Oct 31, 2023
@kueda
Copy link
Member

kueda commented Nov 1, 2023

Hey folks. In general, if you have questions, feature requests (like this), or bug reports, please post them to the iNat Forum instead of here on Github. We use Github for organizing work that we've decided to do, not for discussing work that we might or might not do.

That said, we talked this over and agree it would be a good thing to publish these APKs on Github, albeit not a very high priority, so I'm just going to respecify this a bit:

  • Add a step to our Fastlane build process to make a Github release and push the APK there like we do in iNaturalistReactNative
  • Add an e2e test that ensures location does get fetched on an AOSP emulator (we already use an AOSP emulator so this is mostly just writing the test)

Also FWIW, this app uses react-native-maps, which will include the Google Maps SDK on Android and make it ineligible for inclusion in F-Droid. I'm not sure if it will run on GrapheneOS

@DiagonalArg
Copy link
Author

DiagonalArg commented Nov 2, 2023

@kueda / Point taken regarding the iNat Forum, though since it fits firmly within this present discussion, perhaps as a longer range plan, you might consider using, or making as an option, OpenStreetMaps, rather than GoogleMaps.

Thank you and your colleagues for all your work!

@kaibagley
Copy link

Hey everyone, wondering if there's been any word on the progress of this. Also using GrapheneOS without Google services, so unable to install from GPlay.

Thanks for the great work!

@kvangork kvangork added the Seek label Nov 19, 2024 — with Linear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Seek
Projects
None yet
Development

No branches or pull requests

5 participants