Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flash to AR Camera #609

Open
jtklein opened this issue Jul 19, 2023 · 0 comments
Open

Add flash to AR Camera #609

jtklein opened this issue Jul 19, 2023 · 0 comments

Comments

@jtklein
Copy link
Contributor

jtklein commented Jul 19, 2023

This issue was originally added to the https://github.com/inaturalist/react-native-inat-camera:

On the AR camera, we want to add an option to turn on the camera flash while the user is using the camera. I have two options, with option 1 being the preferred route.

  1. My ideal scenario is to have a button that can be clicked on and off, so that the flash can remain on while the user is using the AR Camera to scan, and not just when they take a photo. That would make the Camera easier to use in low light, and would also make it easier to focus on organisms with the flash constantly on. This would mean there are two states that the user can toggle by pressing the flash button, which would turn the camera flashlight on and off:
  • flash OFF (default state): flashlight is off while the AR camera is open
  • flash ON: flashlight is on while the AR camera is open
  1. If that's not feasible, the flash could function similarly to how most camera phones do flash: only going off when the shutter button is pressed to take a picture. This would mean three states that the user can toggle between. These states can be changed at any time, and only affect the behavior of the flash after the camera button is pressed:
  • flash AUTO (default state): when shutter button is pressed, flash will go off depending on how light/dark it is
  • flash ON: when shutter button is pressed, flash will go off
  • flash OFF: when shutter button is pressed, flash will not go off

I've added states for all of these on Zeplin:

I will create custom flash icons for these, so when folks begin working on this, let me know and I'll get those icons over to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants