From 9ce28d5112acc514a40e73a950e855b9e6b5fad5 Mon Sep 17 00:00:00 2001
From: Brujo Benavides <fernando.benavides@adroll.com>
Date: Tue, 17 Jul 2018 09:08:41 -0300
Subject: [PATCH] Add proper test and docs for format_status/2 support

---
 test/wpool_process_SUITE.erl | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/test/wpool_process_SUITE.erl b/test/wpool_process_SUITE.erl
index 2e2026b..cb53c42 100644
--- a/test/wpool_process_SUITE.erl
+++ b/test/wpool_process_SUITE.erl
@@ -30,6 +30,7 @@
         , cast/1
         , call/1
         , continue/1
+        , format_status/1
         , no_format_status/1
         , stop/1
         ]).
@@ -169,6 +170,17 @@ continue(_Config) ->
 
   {comment, []}.
 
+-spec format_status(config()) -> {comment, []}.
+format_status(_Config) ->
+  %% echo_server implements format_status/2
+  {ok, Pid} = wpool_process:start_link(?MODULE, echo_server, {ok, state}, []),
+  %% therefore it returns {formatted_state, State} as its status and we just pass it through
+  {status, Pid, {module, gen_server}, SItems} = sys:get_status(Pid),
+  [state] = [S || SItemList = [_|_] <- SItems, {formatted_state, S} <- SItemList],
+  %% this code is actually what we use to retrieve the state in other tests
+  state = get_state(Pid),
+  {comment, []}.
+
 -spec no_format_status(config()) -> {comment, []}.
 no_format_status(_Config) ->
   %% crashy_server doesn't implement format_status/2
@@ -306,6 +318,12 @@ complete_coverage(_Config) ->
 
   {comment, []}.
 
+
+%% @doc We can use this function in tests since echo_server implements format_status/2
+%%      by returning the state as a tuple {formatted_state, S}.
+%%      We can safely grab it from the result of sys:get_status/1
+%% @see gen_server:format_status/2
+%% @see sys:get_status/2
 get_state(Atom) when is_atom(Atom) ->
   get_state(whereis(Atom));
 get_state(Pid) ->