Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate the github.com/testifysec/archivista-api as an Archivista Package #113

Closed
kairoaraujo opened this issue Dec 8, 2023 · 1 comment · Fixed by #120
Closed

Migrate the github.com/testifysec/archivista-api as an Archivista Package #113

kairoaraujo opened this issue Dec 8, 2023 · 1 comment · Fixed by #120
Labels
needs triage

Comments

@kairoaraujo
Copy link
Collaborator

The current Archivista uses the dependency github.com/testifysec/archivista-api.
It can be found on:

archivista/internal/server/server.go

Line 30 in a63661d

archivistaapi "github.com/testifysec/archivista-api"

archivista/cmd/archivistactl/cmd/store.go

Line 23 in a63661d

archivistaapi "github.com/testifysec/archivista-api"

archivista/cmd/archivistactl/cmd/retrieve.go

Line 24 in a63661d

archivistaapi "github.com/testifysec/archivista-api"

archivista/cmd/archivistactl/cmd/search.go

Line 23 in a63661d

archivistaapi "github.com/testifysec/archivista-api"

The idea is to move this dependency as an Archivista package (pkg/archivista-api)
@kairoaraujo
Copy link
Collaborator Author

I'm tagging @mikhailswift to review if this is the correct idea.

kairoaraujo added a commit to kairoaraujo/archivista that referenced this issue Dec 12, 2023
@kairoaraujo
refactoring: testifysec/archivista-api as a pkg
9245b73 
The current "github.com/testifysec/archivista-api" was detached from
the Archivista from the historical strategy by TestifySec.

TestifySec donated the Archivista project to the in-toto project,
which makes more sense to the API package being part of the
Archivista source code.

This commit adds "github.com/testifysec/archivista-api" as pkg in
Archivista.

Closes in-toto#113

Signed-off-by: Kairo de Araujo <[email protected]>
@kairoaraujo kairoaraujo mentioned this issue Dec 12, 2023
Merged
kairoaraujo added a commit to kairoaraujo/archivista that referenced this issue Dec 12, 2023
@kairoaraujo
refactoring: testifysec/archivista-api as a pkg
57cc1cb 
The current "github.com/testifysec/archivista-api" was detached from
the Archivista from the historical strategy by TestifySec.

TestifySec donated the Archivista project to the in-toto project,
which makes more sense to the API package being part of the
Archivista source code.

This commit adds "github.com/testifysec/archivista-api" as pkg in
Archivista.

Closes in-toto#113

Signed-off-by: Kairo de Araujo <[email protected]>
@kairoaraujo kairoaraujo mentioned this issue Dec 12, 2023
Merged
jkjell pushed a commit that referenced this issue Dec 12, 2023
@kairoaraujo
refactoring: testifysec/archivista-api as a pkg (#120)
fd6b6e2 
The current "github.com/testifysec/archivista-api" was detached from
the Archivista from the historical strategy by TestifySec.

TestifySec donated the Archivista project to the in-toto project,
which makes more sense to the API package being part of the
Archivista source code.

This commit adds "github.com/testifysec/archivista-api" as pkg in
Archivista.

Closes #113

Signed-off-by: Kairo de Araujo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactoring: testifysec/archivista-api as a pkg kairoaraujo/archivista
1 participant
@kairoaraujo