-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arbitrary-module-namespace-identifier is showing an error in tests #3010
Comments
Notably they can't be string literals in JS before ES2021. and microsoft/TypeScript#40594 is the TS issue to support them. Since I haven't dug into this further yet, I'll say that if the test case shouldn't be running (because the failure is expected) then it should be skipped when expected to fail; if it should be working, then it should be fixed :-) |
Thanks! I was about to file an issue with TypeScript - don't know why I couldn't find it :-). I don't know what the expectation is here - the |
The solution I'd like there is attempted in PRs like #2482 - basically, run each test case in multiple parsers, transparently, and the test case only defines the language features it's using. However, I don't think anything's using this technique here yet (eslint-plugin-react uses it extensively already) |
When running the tests locally, I see an odd error:
Module export names can indeed be string literals in JavaScript.
But note that module export names cannot be string literals in TypeScript, and it seems the TypeScript compiler also mangles these.
The text was updated successfully, but these errors were encountered: