You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Comment by Nander on the PR feat/refactor AppState, add FeatTrait
"I guess perhaps each Feature should have the ability to set its persistence strategy, either pure json file or stronghold. So pub async fn save_state(app_state: &AppState) would be pub async fn save_state(app_state: Box) or something similar.
Perhaps even better it could/should be implemented via the FeatTrait. (for another time though, I think the current solution, although not super clean, simply does the job)."
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Comment by Nander on the PR feat/refactor
AppState
, addFeatTrait
"I guess perhaps each Feature should have the ability to set its persistence strategy, either pure json file or stronghold. So pub async fn save_state(app_state: &AppState) would be pub async fn save_state(app_state: Box) or something similar.
Perhaps even better it could/should be implemented via the FeatTrait. (for another time though, I think the current solution, although not super clean, simply does the job)."
Beta Was this translation helpful? Give feedback.
All reactions