Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

At least the home page is failing WAVE, perhaps others #121

Open
mathieuhendey opened this issue Jun 8, 2019 · 4 comments
Open

At least the home page is failing WAVE, perhaps others #121

mathieuhendey opened this issue Jun 8, 2019 · 4 comments
Labels
accessibility Causes issues for people who require screen readers bug Something isn't working good first issue Good for newcomers

Comments

@mathieuhendey
Copy link
Contributor

mathieuhendey commented Jun 8, 2019

We have quite a few WAVE errors on at least the homepage. We should be running WAVE on all new screens, and I recommend that we doublecheck this before merging again. Or set up CI/CD


image

@mathieuhendey mathieuhendey added accessibility Causes issues for people who require screen readers bug Something isn't working good first issue Good for newcomers labels Jun 8, 2019
@mathieuhendey mathieuhendey changed the title At least the hoee page is failing WAVE, perhaps others At least the home page is failing WAVE, perhaps others Jun 8, 2019
@eostrom
Copy link
Contributor

eostrom commented Aug 2, 2019

I can't get WAVE to work on the home page at all, in Chrome or Firefox. It puts up a loading spinner, logs some console errors, and hangs indefinitely.

Bright side, it gets 100% on Lighthouse's accessibility audit.

@Cazaimi
Copy link

Cazaimi commented Oct 6, 2019

@mathieuhendey , may I take up this issue?

@heatherpekrul
Copy link

WAVE is a good extension, but the Axe Coconut extension is more robust and includes more details, and occasionally catches issues that WAVE does not. I'd recommend it for accessibility testing over WAVE.

@andrew-pyle
Copy link
Contributor

I just submitted a PR that adds eslint-plugin-jsx-a11y checking to git pre-commit hooks. This is similar to WAVE, and easy to enforce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Causes issues for people who require screen readers bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants