Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Upload Case Insensitive Glob Ignore Pattern Not Working As Expected #14048

Open
3 tasks
rholloway opened this issue Nov 10, 2024 · 0 comments
Open
3 tasks

Comments

@rholloway
Copy link

The bug

When using the CLI, the --ignore option seems to have a bug/unexpected output related to case sensitivity. For instance, if I have @eaDir directories in my folders and want to exclude it, the following glob pattern does NOT exclude them and all the nested files are still imported.

immich upload --ignore **/\@eaDir/** --recursive --dry-run Photos/

However, the following command appears to ignore them as expected.

immich upload --ignore **/\@eadir/** --recursive --dry-run Photos/

This may be by design - I see https://github.com/immich-app/immich/blob/main/cli/src/utils.ts#L158 is where it's being done using fast-glob, and it explicitly is set to caseSensitive: false. However, if this means the glob pattern should also be all lowercase, then that should be made more clear in the docs. The current docs imply that you need to match case (for instance, specifically stating how to exclude **/Raw/** files.

The OS that Immich Server is running on

Ubuntu 24

Version of Immich Server

v1.120.0

Version of Immich Mobile App

v1.120.1

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

N/A

Your .env content

N/A

Reproduction steps

  1. Create some folders that include directories @eaDir with images inside. Ensure uppercase D and put inside photos/
  2. Run iimich upload --ignore **/\@eaDir/** photos/ and note eadir files are not excluded
    ...

Relevant log output

No response

Additional information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant